[WIP] improve(HubPoolClient): Don't throw on token resolution failure#643
Draft
[WIP] improve(HubPoolClient): Don't throw on token resolution failure#643
Conversation
This is too violent for a lot of use cases and requires callers to wrap their calls in try/catch statements, which has its own set of problems. Instead, just return undefined if the requested token can't be resolved and allow the caller to decide on how to respond to that.
Signed-off-by: bennett <bennett@umaproject.org>
bmzig
reviewed
Sep 3, 2024
|
|
||
| updateRunningBalance(runningBalances, repaymentChainId, l1TokenCounterpart, totalRefundAmount); | ||
| updateRunningBalance(realizedLpFees, repaymentChainId, l1TokenCounterpart, totalRealizedLpFee); | ||
| if (isDefined(l1TokenCounterpart)) { |
Contributor
There was a problem hiding this comment.
Leaving a comment here since this is just a temporary fix to let the code compile. I'm pretty sure this is a bad idea to do since if l1TokenCounterpart is undefined, then we probably do want to throw an error. (Maybe we should just assert that here).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP - there's lots of users of this function so there's a bit of fallout from the change. I'll update it progressively as each case is addressed.
This is too violent for a lot of use cases and requires callers to wrap their calls in try/catch statements, which has its own set of problems. Instead, just return undefined if the requested token can't be resolved and allow the caller to decide on how to respond to that.