fix: [codex] Only count completed Binance withdrawals in callers#3176
Merged
nicholaspai merged 5 commits intomasterfrom Apr 8, 2026
Merged
Conversation
nicholaspai
force-pushed
the
npai/codex/binance-completed-withdrawal-filtering
branch
from
3a6ab0a to
5aa1b72
Compare
nicholaspai
changed the base branch from
npai/codex/binance-withdraw-failure-handling
to
master
nicholaspai
requested review from
bmzig,
dohaki,
mrice32 and
pxrl
as code owners
pxrl
previously approved these changes
Apr 8, 2026
* handle failed Binance withdrawals * preserve failed Binance withdrawal tags * match only terminal Binance withdrawals * reuse Binance withdrawal status enum
nicholaspai
deleted the
npai/codex/binance-completed-withdrawal-filtering
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
isCompletedBinanceWithdrawal()insrc/utils/BinanceUtils.tssrc/finalizer/utils/binance.tssrc/adapter/bridges/BinanceCEXBridge.tssrc/adapter/l2Bridges/BinanceCEXBridge.tsWhy
getBinanceWithdrawals()is a generic history fetcher and should continue returning the raw Binance history. But several callers are using that history for accounting or receipt lookups that only make sense once a withdrawal has actually completed.Before this change, those callers could count non-completed Binance withdrawals as if funds had already moved. This PR keeps the shared utility generic and fixes the behavior at the call sites that require completed-only semantics.
Validation
yarn test test/BinanceUtils.tsyarn eslint src/utils/BinanceUtils.ts src/adapter/bridges/BinanceCEXBridge.ts src/adapter/l2Bridges/BinanceCEXBridge.ts src/finalizer/utils/binance.ts test/BinanceUtils.tsyarn build