Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97bbee055b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| run: | | ||
| VERSION=$(node -p "require('./package.json').version") | ||
| # Extract pre-release identifier (e.g. "beta" from "1.0.0-beta.1") | ||
| PRE=$(echo "$VERSION" | sed -n 's/.*-\([a-zA-Z]*\).*/\1/p') |
There was a problem hiding this comment.
The sed pattern only captures alphabetic characters after the last -, so valid prerelease versions such as 1.2.3-rc1.0 or 1.2.3-alpha-beta.1 are parsed incorrectly (rc / beta), and identifiers that begin with non-letters can become empty. In those cases, the publish step can fall back to plain npm publish and ship a prerelease as latest, which is a production-impacting channel mistake.
Useful? React with 👍 / 👎.
| - name: Determine publish tag | ||
| id: tag | ||
| run: | | ||
| VERSION=$(node -p "require('./package.json').version") |
There was a problem hiding this comment.
This workflow now derives publish behavior only from package.json and no longer validates release metadata (tag/version match and prerelease alignment) before publishing. If a GitHub release is created with an incorrect tag or prerelease flag, the job will still publish the package version from the repo, which can publish an unintended version/channel and is difficult to undo in npm.
Useful? React with 👍 / 👎.
1 participant
No description provided.