fix: coordinates at lat=0 or lon=0 silently rejected#732
Merged
accius merged 3 commits intoaccius:Stagingfrom Mar 15, 2026
Merged
fix: coordinates at lat=0 or lon=0 silently rejected#732accius merged 3 commits intoaccius:Stagingfrom
accius merged 3 commits intoaccius:Stagingfrom
Conversation
Replaces truthy guards (if lat && lon) with explicit null checks (lat != null) so coordinates on the equator or prime meridian are no longer silently rejected. Fixes accius#729. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ightning Applies the same null-check correction from accius#729 to three additional files not covered by the original report. Spots and DE locations at lat=0 or lon=0 now render correctly on all map views. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Missed instance from accius#729 — decodes at the equator or prime meridian were being filtered out before reaching the map. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Good catch. |
Owner
|
nice work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #729. JavaScript's truthy check treats
0as falsy, causing valid coordinates on the equator (lat=0) or prime meridian (lon=0) to be ignored as if missing.if (lat && lon)/if (!lat || !lon)guards with explicit!= null/== nullchecks across 9 files (18 occurrences total)Test plan
Type of change
Checklist
server.js: caches have TTLs and size caps (we serve 2,000+ concurrent users)var(--accent-cyan), etc.).bak,.old,console.logdebug lines, or test scripts included