fix: audit operator fixes and PHP 8.4 compat

.gitignore

@@ -5,3 +5,8 @@ composer.lock
 coverage.xml
 .phpunit.cache
 phpunit.xml
+
+.claude/
+.DS_Store
+AUDIT_REPORT.md
+FIXES_IMPLEMENTED.md

composer.json

@@ -8,7 +8,15 @@
         "ext-json": "*"
     },
     "require-dev": {
-        "phpunit/phpunit": "^9.5.26"
+        "phpunit/phpunit": "^9.5.26",
+        "react/http": "^1.9",
+        "react/async": "^4.0",
+        "react/promise": "^3.0"
+    },
+    "suggest": {
+        "react/http": "Required for async HTTP support with ReactPHP",
+        "react/async": "Required for sync-over-async operations with ReactPHP",
+        "react/promise": "Required for async operations"
     },
     "license": "MIT",
     "autoload": {
@@ -27,5 +35,8 @@
             "email": "ayesh@aye.sh"
         }
     ],
-    "keywords": ["absmartly"]
+    "keywords": ["absmartly"],
+    "scripts": {
+        "test": "phpunit"
+    }
 }

src/ABsmartly.php

@@ -0,0 +1,164 @@
+<?php
+
+namespace ABSmartly\SDK;
+
+use ABSmartly\SDK\Client\Client;
+use ABSmartly\SDK\Client\ClientConfig;
+use ABSmartly\SDK\Context\AsyncContextDataProvider;
+use ABSmartly\SDK\Context\Context;
+use ABSmartly\SDK\Context\ContextConfig;
+use ABSmartly\SDK\Context\ContextData;
+use ABSmartly\SDK\Context\ContextDataProvider;
+use ABSmartly\SDK\Context\ContextPublisher;
+use ABSmartly\SDK\Context\ContextEventLogger;
+use ABSmartly\SDK\Http\HTTPClient;
+use React\Promise\PromiseInterface;
+
+use function React\Promise\resolve;
+
+class ABsmartly {
+
+	private Client $client;
+	private ContextPublisher $handler;
+	private ContextDataProvider $provider;
+	private ?ContextEventLogger $eventLogger;
+
+	public function __construct(Config $config) {
+		$this->client = $config->getClient();
+		$this->provider = $config->getContextDataProvider();
+		$this->handler = $config->getContextEventHandler();
+		$this->eventLogger = $config->getContextEventLogger();
+	}
+
+	/**
+	 * @param string $endpoint URL to your API endpoint. Most commonly "your-company.absmartly.io".
+	 * @param string $apiKey API key which can be found on the Web Console.
+	 * @param string $application Name of the application where the SDK is installed. Applications are created on the
+	 *                  Web Console and should match the applications where your experiments will be running.
+	 * @param string $environment Environment of the platform where the SDK is installed. Environments are created on
+	 *                  the Web Console and should match the available environments in your infrastructure.
+	 * @param int $retries The number of retries before the SDK stops trying to connect.
+	 * @param int $timeout Amount of time, in milliseconds, before the SDK will stop trying to connect.
+	 * @param callable|null $eventLogger A callback function which runs after SDK events.
+	 * @return ABsmartly ABsmartly instance created using the credentials and details above.
+	 */
+	public static function createSimple(
+		string $endpoint,
+		string $apiKey,
+		string $application,
+		string $environment,
+		int $retries = 5,
+		int $timeout = 3000,
+		?callable $eventLogger = null
+	): ABsmartly {
+		$clientConfig = new ClientConfig(
+			$endpoint,
+			$apiKey,
+			$application,
+			$environment,
+		);
+		$clientConfig->setRetries($retries);
+		$clientConfig->setTimeout($timeout);
+
+		$client = new Client($clientConfig, new HTTPClient());
+		$sdkConfig = new Config($client);
+		if ($eventLogger !== null) {
+			$sdkConfig->setContextEventLogger(new \ABSmartly\SDK\Context\ContextEventLoggerCallback($eventLogger));
+		}
+		return new ABsmartly($sdkConfig);
+	}
+
+	/**
+	 * @deprecated Use createSimple() instead. This method has $environment and $application in the wrong order
+	 *             relative to ClientConfig::__construct(). createSimple() fixes this with the correct order:
+	 *             endpoint, apiKey, application, environment.
+	 *
+	 * @param string $endpoint URL to your API endpoint. Most commonly "your-company.absmartly.io".
+	 * @param string $apiKey API key which can be found on the Web Console.
+	 * @param string $environment Environment of the platform where the SDK is installed. Environments are created on
+	 *                  the Web Console and should match the available environments in your infrastructure.
+	 * @param string $application Name of the application where the SDK is installed. Applications are created on the
+	 *                  Web Console and should match the applications where your experiments will be running.
+	 * @param int $retries The number of retries before the SDK stops trying to connect.
+	 * @param int $timeout Amount of time, in milliseconds, before the SDK will stop trying to connect.
+	 * @param callable|null $eventLogger A callback function which runs after SDK events.
+	 * @return ABsmartly ABsmartly instance created using the credentials and details above.
+	 */
+	public static function createWithDefaults(
+		string $endpoint,
+		string $apiKey,
+		string $environment,
+		string $application,
+		int $retries = 5,
+		int $timeout = 3000,
+		?callable $eventLogger = null
+	): ABsmartly {
+
+		$clientConfig = new ClientConfig(
+			$endpoint,
+			$apiKey,
+			$application,
+			$environment,
+		);
+		$clientConfig->setRetries($retries);
+		$clientConfig->setTimeout($timeout);
+
+		$client = new Client($clientConfig, new HTTPClient());
+		$sdkConfig = new Config($client);
+		if ($eventLogger !== null) {
+			$sdkConfig->setContextEventLogger(new \ABSmartly\SDK\Context\ContextEventLoggerCallback($eventLogger));
+		}
+		return new ABsmartly($sdkConfig);
+	}
+
+	public function createContext(ContextConfig $contextConfig): Context {
+		$this->applyEventLogger($contextConfig);
+		return Context::createFromContextConfig($this, $contextConfig, $this->provider, $this->handler);
+	}
+
+	public function createContextWithData(ContextConfig $contextConfig, ContextData $contextData): Context {
+		$this->applyEventLogger($contextConfig);
+		return Context::createFromContextConfig($this, $contextConfig, $this->provider, $this->handler, $contextData);
+	}
+
+	private function applyEventLogger(ContextConfig $contextConfig): void {
+		if ($this->eventLogger !== null && $contextConfig->getEventLogger() === null) {
+			$contextConfig->setEventLogger($this->eventLogger);
+		}
+	}
+
+	public function createContextAsync(ContextConfig $contextConfig): PromiseInterface {
+		$this->applyEventLogger($contextConfig);
+		if (!$this->provider instanceof AsyncContextDataProvider) {
+			return resolve($this->createContext($contextConfig));
+		}
+
+		return $this->provider->getContextDataAsync()
+			->then(fn($data) => $this->createContextWithData($contextConfig, $data));
+	}
+
+	public function createContextPending(ContextConfig $contextConfig): array {
+		$this->applyEventLogger($contextConfig);
+		$context = Context::createPending($this, $contextConfig, $this->provider, $this->handler);
+
+		if (!$this->provider instanceof AsyncContextDataProvider) {
+			$promise = resolve(null)->then(function() use ($context) {
+				$data = $this->provider->getContextData();
+				$context->setContextData($data);
+				return $context;
+			});
+		} else {
+			$promise = $this->provider->getContextDataAsync()
+				->then(function($data) use ($context) {
+					$context->setContextData($data);
+					return $context;
+				});
+		}
+
+		return ['context' => $context, 'promise' => $promise];
+	}
+
+	public function close(): void {
+		$this->client->close();
+	}
+}

src/Assignment.php

@@ -9,8 +9,8 @@ class Assignment {
 	public int $iteration = 0;
 	public int $fullOnVariant = 0;
 	public string $name = '';
-	public ?string $unitType;
-	public array $trafficSplit;
+	public ?string $unitType = null;
+	public array $trafficSplit = [];
 	public int $variant = 0;
 	public bool $assigned = false;
 	public bool $overridden = false;
@@ -19,8 +19,9 @@ class Assignment {
 	public bool $custom = false;
 
 	public bool $audienceMismatch = false;
-	public stdClass $variables;
+	public ?stdClass $variables = null;
 
-	public bool $exposed;
+	public bool $exposed = false;
+	public int $attrsSeq = 0;
 }
 

src/Client/AsyncClientInterface.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace ABSmartly\SDK\Client;
+
+use ABSmartly\SDK\PublishEvent;
+use React\Promise\PromiseInterface;
+
+interface AsyncClientInterface extends ClientInterface {
+	public function getContextDataAsync(): PromiseInterface;
+	public function publishAsync(PublishEvent $publishEvent): PromiseInterface;
+}

src/Client/Client.php

@@ -3,29 +3,38 @@
 namespace ABSmartly\SDK\Client;
 
 use ABSmartly\SDK\Context\ContextData;
+use ABSmartly\SDK\Http\HttpClientInterface;
+use ABSmartly\SDK\Http\AsyncHttpClientInterface;
 use ABSmartly\SDK\Http\HTTPClient;
 use ABSmartly\SDK\PublishEvent;
+use React\Promise\PromiseInterface;
 
 use function json_decode;
 use function json_encode;
+use function React\Promise\resolve;
 use function rtrim;
 
 use const JSON_THROW_ON_ERROR;
 
-class Client {
+class Client implements AsyncClientInterface {
 	protected const VERSION = '1.0.3';
-	private HTTPClient $httpClient;
+	private HttpClientInterface $httpClient;
 	private string $url;
 	private array $query;
 	private array $headers;
 
-	public function __construct(ClientConfig $clientConfig, ?HTTPClient $HTTPClient = null) {
+	public function __construct(ClientConfig $clientConfig, ?HttpClientInterface $HTTPClient = null) {
 		if (!$HTTPClient) {
 			$HTTPClient = new HTTPClient();
 		}
 		$this->httpClient = $HTTPClient;
-		$this->httpClient->timeout = $clientConfig->getTimeout();
-		$this->httpClient->retries = $clientConfig->getRetries();
+
+		if (property_exists($this->httpClient, 'timeout')) {
+			$this->httpClient->timeout = $clientConfig->getTimeout();
+		}
+		if (property_exists($this->httpClient, 'retries')) {
+			$this->httpClient->retries = $clientConfig->getRetries();
+		}
 
 		$this->url = rtrim($clientConfig->getEndpoint(), '/') .'/context';
 		$this->query = [
@@ -45,23 +54,48 @@ public function __construct(ClientConfig $clientConfig, ?HTTPClient $HTTPClient
 
 
 	private function authRequest(): void {
-
+		if (empty($this->headers['X-API-Key'])) {
+			throw new \ABSmartly\SDK\Exception\RuntimeException(
+				'API key is not configured. Please set a valid API key in ClientConfig.'
+			);
+		}
 	}
 
 	public function getContextData(): ContextData {
 		$this->authRequest();
 		$response = $this->httpClient->get($this->url, $this->query, $this->headers);
-		$response = $this->decode($response->content);
-		return new ContextData($response->experiments);
+		$decoded = $this->decode($response->content);
+		return new ContextData($decoded->experiments);
+	}
+
+	public function getContextDataAsync(): PromiseInterface {
+		if (!$this->httpClient instanceof AsyncHttpClientInterface) {
+			return resolve($this->getContextData());
+		}
+
+		$this->authRequest();
+		return $this->httpClient
+			->getAsync($this->url, $this->query, $this->headers)
+			->then(fn($response) => new ContextData($this->decode($response->content)->experiments));
 	}
 
 	public function publish(PublishEvent $publishEvent): void {
 		$data = $this->encode($publishEvent);
 		$this->httpClient->put($this->url, $this->query, $this->headers, $data);
 	}
 
+	public function publishAsync(PublishEvent $publishEvent): PromiseInterface {
+		if (!$this->httpClient instanceof AsyncHttpClientInterface) {
+			$this->publish($publishEvent);
+			return resolve(null);
+		}
+
+		$data = $this->encode($publishEvent);
+		return $this->httpClient->putAsync($this->url, $this->query, $this->headers, $data);
+	}
+
 	public function decode(string $jsonString): object {
-		return json_decode($jsonString, false, 16, JSON_THROW_ON_ERROR);
+		return json_decode($jsonString, false, 512, JSON_THROW_ON_ERROR);
 	}
 
 	public function encode(object $object): string {
@@ -71,4 +105,8 @@ public function encode(object $object): string {
 	public function close(): void {
 		$this->httpClient->close();
 	}
+
+	public function isAsync(): bool {
+		return $this->httpClient instanceof AsyncHttpClientInterface;
+	}
 }

src/Client/ClientConfig.php

@@ -4,7 +4,6 @@
 
 use ABSmartly\SDK\Exception\InvalidArgumentException;
 
-use function get_class;
 use function str_repeat;
 use function strlen;
 
@@ -23,6 +22,9 @@ public function __construct(
 		string $application,
 		string $environment
 	) {
+		if (($endpoint === '' && $apiKey !== '') || ($endpoint !== '' && $apiKey === '')) {
+			error_log('ABsmartly SDK Warning: ClientConfig created with empty endpoint or API key. This may cause runtime errors.');
+		}
 
 		$this->apiKey = $apiKey;
 		$this->application = $application;
@@ -40,7 +42,6 @@ public function __debugInfo(): array {
 			'application' => $this->application,
 			'endpoint' => $this->endpoint,
 			'environment' => $this->environment,
-			'eventLogger' => isset($this->eventLogger) ? get_class($this->eventLogger) : null,
 		];
 	}
 

src/Client/ClientInterface.php

@@ -0,0 +1,12 @@
+<?php
+
+namespace ABSmartly\SDK\Client;
+
+use ABSmartly\SDK\Context\ContextData;
+use ABSmartly\SDK\PublishEvent;
+
+interface ClientInterface {
+	public function getContextData(): ContextData;
+	public function publish(PublishEvent $publishEvent): void;
+	public function close(): void;
+}