Fix GentooImporter InvalidVersion error by stripping slots #2136
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aditya kumar singh <143548997+Adityakk9031@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
GentooImporter
was failing with univers.versions.InvalidVersion errors when encountering package versions containing slots (e.g., '3.24.48:3'). This happened because univers.versions.GentooVersion does not support the slot syntax in the version string.
Fixes #1921
Solution
Updated
vulnerabilities/importers/gentoo.py
to strip the slot suffix (starting with :) from version strings before passing them to GentooVersion. This ensures that only the version number is used for comparison, avoiding the validation error.
Changes
Modified GentooImporter.affected_and_safe_purls to split version strings on : and take the first part.
Verification