feat(ddic): add full DDIC object type support (DOMA, DTEL, TABL, TTYP)

packages/adk/src/base/adt.ts

@@ -37,6 +37,11 @@ export type {
   TransportGetResponse,
   ProgramResponse as ProgramResponseUnion,
   FunctionGroupResponse as FunctionGroupResponseUnion,
+  DomainResponse,
+  DataElementResponse,
+  TableResponse,
+  StructureResponse,
+  TableTypeResponse,
 } from '@abapify/adt-client';
 
 // CRUD contract types for typed ADK base model
@@ -128,6 +133,8 @@ export interface AdkContract {
   readonly programs: AdtContracts['programs'];
   /** Functions contracts (function groups) */
   readonly functions: AdtContracts['functions'];
+  /** DDIC contracts (domains, data elements, structures, tables, table types) */
+  readonly ddic: AdtContracts['ddic'];
 }
 
 /**
@@ -145,5 +152,6 @@ export function createAdkContract(client: AdtClient): AdkContract {
     repository: client.adt.repository,
     programs: client.adt.programs,
     functions: client.adt.functions,
+    ddic: client.adt.ddic,
   };
 }

packages/adk/src/base/kinds.ts

@@ -67,6 +67,10 @@ import type {
   AdkTransportTask,
 } from '../objects/cts/transport/transport';
 import type { AdkObject } from './model';
+import type { AdkDomain } from '../objects/ddic/doma/doma.model';
+import type { AdkDataElement } from '../objects/ddic/dtel/dtel.model';
+import type { AdkTable, AdkStructure } from '../objects/ddic/tabl/tabl.model';
+import type { AdkTableType } from '../objects/ddic/ttyp/ttyp.model';
 
 /**
  * Maps ADK kind to concrete object type
@@ -91,5 +95,14 @@ export type AdkObjectForKind<K extends AdkKind> = K extends typeof Class
             ? AdkTransportRequest
             : K extends typeof TransportTask
               ? AdkTransportTask
-              : // Add more mappings as types are implemented
-                AdkObject; // fallback
+              : K extends typeof Domain
+                ? AdkDomain
+                : K extends typeof DataElement
+                  ? AdkDataElement
+                  : K extends typeof Table
+                    ? AdkTable
+                    : K extends typeof Structure
+                      ? AdkStructure
+                      : K extends typeof TableType
+                        ? AdkTableType
+                        : AdkObject; // fallback

packages/adk/src/base/model.ts

@@ -456,6 +456,9 @@ export abstract class AdkObject<K extends AdkKind = AdkKind, D = any> {
   async save(options: SaveOptions = {}): Promise<this> {
     const { transport, mode = 'update' } = options;
 
+    // Reset per-save-attempt state
+    this._unchanged = false;
+
     // Check if object has pending sources (from abapGit deserialization)
     const hasPendingSources = this.hasPendingSources();
 
@@ -475,9 +478,10 @@ export abstract class AdkObject<K extends AdkKind = AdkKind, D = any> {
       try {
         await this.lock(transport);
       } catch (e) {
-        // For upsert, only fallback to create if it's a 404 Not Found error
-        if (mode === 'upsert' && this.isNotFoundError(e)) {
-          return this.save({ ...options, mode: 'create' });
+        // For upsert, fallback to create if object doesn't exist (404)
+        // or endpoint doesn't support the operation (405 - common for DDIC types)
+        if (mode === 'upsert' && this.shouldFallbackToCreate(e)) {
+          return this.fallbackToCreate(options);
         }
         throw e;
       }
@@ -510,9 +514,14 @@ export abstract class AdkObject<K extends AdkKind = AdkKind, D = any> {
 
       return this;
     } catch (e: unknown) {
-      // For upsert with PUT failure (404), try POST
-      if (mode === 'upsert' && this.isNotFoundError(e)) {
-        return this.save({ ...options, mode: 'create' });
+      // For upsert with PUT failure (404/405), try POST (create)
+      if (mode === 'upsert' && this.shouldFallbackToCreate(e)) {
+        return this.fallbackToCreate(options);
+      }
+      // If PUT returns 422 "already exists" directly in upsert mode
+      if (mode === 'upsert' && this.isAlreadyExistsError(e)) {
+        this._unchanged = true;
+        return this;
       }
       throw e;
     } finally {
@@ -586,6 +595,49 @@ export abstract class AdkObject<K extends AdkKind = AdkKind, D = any> {
     return false;
   }
 
+  /**
+   * Upsert fallback: try POST (create), treat 422 "already exists" as unchanged.
+   * Extracted to avoid duplication in lock-catch and saveViaContract-catch paths.
+   */
+  private async fallbackToCreate(options: SaveOptions): Promise<this> {
+    try {
+      return await this.save({ ...options, mode: 'create' });
+    } catch (createErr) {
+      if (this.isAlreadyExistsError(createErr)) {
+        this._unchanged = true;
+        return this;
+      }
+      throw createErr;
+    }
+  }
+
+  /**
+   * Check if error suggests the object doesn't exist or the operation
+   * is not supported for the current state.
+   *
+   * Some SAP DDIC endpoints (TABL, TTYP) return 405 Method Not Allowed
+   * instead of 404 when attempting to lock or PUT a non-existent object.
+   * In upsert mode, both should trigger a fallback to POST (create).
+   */
+  protected shouldFallbackToCreate(e: unknown): boolean {
+    return (
+      this.isNotFoundError(e) ||
+      (e instanceof Error &&
+        (e.message.includes('405') || e.message.includes('Method Not Allowed')))
+    );
+  }
+
+  /**
+   * Check if error is a 422 "already exists" from a POST create attempt
+   */
+  protected isAlreadyExistsError(e: unknown): boolean {
+    const msg = e instanceof Error ? e.message.toLowerCase() : '';
+    return (
+      (msg.includes('422') || msg.includes('unprocessable')) &&
+      msg.includes('already exists')
+    );
+  }
+
   /**
    * Check if object has pending sources to save
    * Subclasses with source code (classes, interfaces) override this

packages/adk/src/base/object-set.ts

@@ -345,7 +345,11 @@ export class AdkObjectSet {
    */
   async unlockAll(): Promise<void> {
     for (const obj of this.objects) {
-      await obj.unlock();
+      try {
+        await obj.unlock();
+      } catch {
+        // Ignore unlock failures - object may not have been locked
+      }
     }
   }
 

packages/adk/src/index.ts

@@ -45,6 +45,9 @@ export type {
   ProgramResponse,
   FunctionGroupResponse,
   TransportGetResponse,
+  DomainResponse,
+  DataElementResponse,
+  TableTypeResponse,
 } from './base/adt';
 export { createAdkContract } from './base/adt';
 
@@ -103,6 +106,19 @@ export type {
 } from './objects/repository/fugr';
 export { AdkFunctionGroup } from './objects/repository/fugr';
 
+// DDIC types and classes
+export {
+  AdkDomain,
+  AdkDataElement,
+  AdkTable,
+  AdkStructure,
+  AdkTableType,
+  type DomainXml,
+  type DataElementXml,
+  type TableXml,
+  type TableTypeXml,
+} from './objects/ddic';
+
 // CTS types (legacy complex transport)
 export type {
   TransportData,

packages/adk/src/objects/ddic/doma/doma.model.ts

@@ -0,0 +1,55 @@
+/**
+ * DOMA - Domain
+ *
+ * ADK object for ABAP Domains (DOMA).
+ * DDIC objects are metadata-only (no source code).
+ */
+
+import { AdkMainObject } from '../../../base/model';
+import { Domain as DomainKind } from '../../../base/kinds';
+import { getGlobalContext } from '../../../base/global-context';
+import type { AdkContext } from '../../../base/context';
+
+import type { DomainResponse } from '../../../base/adt';
+
+/**
+ * Domain data type - unwrap from schema root element
+ */
+export type DomainXml = DomainResponse['domain'];
+
+/**
+ * ADK Domain object
+ *
+ * Inherits from AdkMainObject which provides:
+ * - name, type, description, version, language, changedBy/At, createdBy/At, links
+ * - package, packageRef, responsible, masterLanguage, masterSystem, abapLanguageVersion
+ *
+ * Domain-specific properties via `data`:
+ * - data.typeInformation (dataType, length, decimals, outputLength)
+ * - data.outputInformation (conversionExit, signPresentation, lowerCase)
+ * - data.fixedValues
+ */
+export class AdkDomain extends AdkMainObject<typeof DomainKind, DomainXml> {
+  static readonly kind = DomainKind;
+  readonly kind = AdkDomain.kind;
+
+  get objectUri(): string {
+    return `/sap/bc/adt/ddic/domains/${encodeURIComponent(this.name.toLowerCase())}`;
+  }
+
+  protected override get wrapperKey() {
+    return 'domain';
+  }
+  protected override get crudContract(): any {
+    return this.ctx.client.adt.ddic.domains;
+  }
+
+  static async get(name: string, ctx?: AdkContext): Promise<AdkDomain> {
+    const context = ctx ?? getGlobalContext();
+    return new AdkDomain(context, name).load();
+  }
+}
+
+// Self-register with ADK registry
+import { registerObjectType } from '../../../base/registry';
+registerObjectType('DOMA', DomainKind, AdkDomain);

packages/adk/src/objects/ddic/doma/index.ts

@@ -0,0 +1,6 @@
+/**
+ * DOMA - Domain
+ */
+
+export { AdkDomain } from './doma.model';
+export type { DomainXml } from './doma.model';

packages/adk/src/objects/ddic/dtel/dtel.model.ts

@@ -0,0 +1,59 @@
+/**
+ * DTEL - Data Element
+ *
+ * ADK object for ABAP Data Elements (DTEL).
+ * DDIC objects are metadata-only (no source code).
+ */
+
+import { AdkMainObject } from '../../../base/model';
+import { DataElement as DataElementKind } from '../../../base/kinds';
+import { getGlobalContext } from '../../../base/global-context';
+import type { AdkContext } from '../../../base/context';
+
+import type { DataElementResponse } from '../../../base/adt';
+
+/**
+ * Data Element data type - unwrap from wrapper root element
+ * SAP wraps DTEL content in a blue:wbobj element extending AdtMainObject
+ */
+export type DataElementXml = DataElementResponse['wbobj'];
+
+/**
+ * ADK Data Element object
+ *
+ * Inherits from AdkMainObject which provides:
+ * - name, type, description, version, language, changedBy/At, createdBy/At, links
+ * - package, packageRef, responsible, masterLanguage, masterSystem, abapLanguageVersion
+ *
+ * Data element-specific properties via `data`:
+ * - data.typeKind, data.typeName, data.dataType
+ * - data.shortDescription, data.mediumDescription, data.longDescription, data.headingDescription
+ * - data.searchHelp
+ */
+export class AdkDataElement extends AdkMainObject<
+  typeof DataElementKind,
+  DataElementXml
+> {
+  static readonly kind = DataElementKind;
+  readonly kind = AdkDataElement.kind;
+
+  get objectUri(): string {
+    return `/sap/bc/adt/ddic/dataelements/${encodeURIComponent(this.name.toLowerCase())}`;
+  }
+
+  protected override get wrapperKey() {
+    return 'wbobj';
+  }
+  protected override get crudContract(): any {
+    return this.ctx.client.adt.ddic.dataelements;
+  }
+
+  static async get(name: string, ctx?: AdkContext): Promise<AdkDataElement> {
+    const context = ctx ?? getGlobalContext();
+    return new AdkDataElement(context, name).load();
+  }
+}
+
+// Self-register with ADK registry
+import { registerObjectType } from '../../../base/registry';
+registerObjectType('DTEL', DataElementKind, AdkDataElement);

packages/adk/src/objects/ddic/dtel/index.ts

@@ -0,0 +1,6 @@
+/**
+ * DTEL - Data Element
+ */
+
+export { AdkDataElement } from './dtel.model';
+export type { DataElementXml } from './dtel.model';

packages/adk/src/objects/ddic/index.ts

@@ -0,0 +1,8 @@
+/**
+ * DDIC - Data Dictionary Objects
+ */
+
+export { AdkDomain, type DomainXml } from './doma';
+export { AdkDataElement, type DataElementXml } from './dtel';
+export { AdkTable, AdkStructure, type TableXml } from './tabl';
+export { AdkTableType, type TableTypeXml } from './ttyp';

packages/adk/src/objects/ddic/tabl/index.ts

@@ -0,0 +1,6 @@
+/**
+ * TABL - Database Table / Structure
+ */
+
+export { AdkTable, AdkStructure } from './tabl.model';
+export type { TableXml } from './tabl.model';