🎨 Palette: Missing aria-expanded on Expand/Collapse Buttons#151
🎨 Palette: Missing aria-expanded on Expand/Collapse Buttons#151
Conversation
Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
What
Added missing
aria-expandedandaria-controlsattributes to the toggle buttons inDashboardFiltersandRootCauseTree.Why
Screen reader users need to know if an expandable section is currently open or closed, and what content the button controls. Without these attributes, the toggles act as standard buttons with no state context.
Before/After
Visually identical (no screenshot attached).
Accessibility
aria-expandedto reflect current toggle state.aria-controlsreferencing dynamic IDs on the controlled containers to explicitly link the trigger to the content.aria-labelto theRootCauseTreeicon-only button to provide an accessible name ("Expand node" / "Collapse node").PR created automatically by Jules for task 15266284037577278859 started by @aarjava