🎨 Palette: Improve accessibility of filter pills#149
Conversation
Added `aria-pressed` to correctly convey toggle state to screen readers. Added explicit keyboard focus styles for accessibility. Added `aria-hidden="true"` to the decorative clear icon to prevent redundant announcements. Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Added `aria-pressed` to correctly convey toggle state to screen readers. Added explicit keyboard focus styles for accessibility. Added `aria-hidden="true"` to the decorative clear icon to prevent redundant announcements. Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
Resolved an issue where ARIMA surrogate coefficient calculation (`phi`) in the forecast backtest could result in NaN when the variance of sequence differences was 0, leading to a CI pipeline failure (`check-models` step). Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
Added `FORECAST_BACKTEST_STALE_DAYS: 7` to the `check-models` CI action to prevent forecast failures. Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
1 participant
💡 What: Improved the accessibility of the
FilterPillscomponent. Addedaria-pressedattributes to correctly announce state changes, added keyboard focus indicators, and hid the decorative ClearXicon from screen readers.🎯 Why: When visually impaired users navigate custom toggle buttons, they need explicit state announcements (like "pressed" or "unpressed") and when keyboard-only users navigate, they need distinct visual indicators. Also preventing redundant icon announcements declutters the audio experience.
📸 Before/After: Visually identical, but keyboard navigation now clearly highlights the active button and clear action.
♿ Accessibility:
aria-pressed={isSelected}for state toggling.focus-visible:ring-2to support keyboard-only navigation.aria-hidden="true"to the decorative icon inside the Clear button.PR created automatically by Jules for task 15515821885408258975 started by @aarjava