fix(errors): align error mappings with A2A spec #1055
Merged
sokoliva merged 2 commits intoa2aproject:mainfrom May 6, 2026
Merged
fix(errors): align error mappings with A2A spec #1055sokoliva merged 2 commits intoa2aproject:mainfrom
sokoliva merged 2 commits intoa2aproject:mainfrom
Conversation
…d VersionNotSupported errors to FAILED_PRECONDITION
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the error mapping for several exception types across gRPC and REST handlers, primarily shifting statuses from UNIMPLEMENTED to FAILED_PRECONDITION and adjusting various HTTP status codes. Feedback indicates that VersionNotSupportedError is missing from the test suite and that exception classes in tests should be referenced without instantiation to comply with project style guidelines.
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/server/events/event_queue_v2.py | 91.19% | 91.71% | 🟢 +0.52% |
| src/a2a/utils/telemetry.py | 90.63% | 91.41% | 🟢 +0.78% |
| Total | 93.01% | 93.03% | 🟢 +0.02% |
Generated by coverage-comment.yml
ishymko
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Aligns A2A error mappings with the canonical mapping in A2A spec.
Changes
grpc_handler.py_ERROR_CODE_MAP: PushNotificationNotSupportedError, UnsupportedOperationError, VersionNotSupportedError → FAILED_PRECONDITION (was UNIMPLEMENTED).errors.pyA2A_REST_ERROR_MAPPING: same three errors' gRPC status updated to FAILED_PRECONDITION; TaskNotCancelableError HTTP 409 → 400; InvalidAgentResponseError HTTP 502 → 500.test_grpc_handler.py: updated parametrized expectations for the two affected gRPC test cases.Issue #1027 🦕