Skip to content

fix: support complete agent card URL in A2ACardResolver #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ehsavoie wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: support complete agent card URL in A2ACardResolver #837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions client/base/src/main/java/org/a2aproject/sdk/A2A.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,14 @@ public static AgentCard getAgentCard(String agentUrl, String relativeCardPath, M
* @throws org.a2aproject.sdk.spec.A2AClientJSONError if the response body cannot be decoded as JSON or validated against the AgentCard schema
*/
public static AgentCard getAgentCard(A2AHttpClient httpClient, String agentUrl, String relativeCardPath, Map<String, String> authHeaders) throws A2AClientError, A2AClientJSONError {
A2ACardResolver resolver = new A2ACardResolver(httpClient, agentUrl, "", relativeCardPath, authHeaders);
return resolver.getAgentCard();
A2ACardResolver resolver = A2ACardResolver.builder()
.httpClient(httpClient)
.baseUrl(agentUrl)
.agentCardPath(relativeCardPath)
.authHeaders(authHeaders)
.build();
return (relativeCardPath == null || relativeCardPath.isBlank())
? resolver.getWellKnownAgentCard()
: resolver.getConfiguredAgentCard();
}
}
2 changes: 1 addition & 1 deletion ...loworld/client/src/main/java/org/a2aproject/sdk/examples/helloworld/HelloWorldClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public class HelloWorldClient {
public static void main(String[] args) {
OpenTelemetrySdk openTelemetrySdk = null;
try {
AgentCard publicAgentCard = new A2ACardResolver(SERVER_URL).getAgentCard();
AgentCard publicAgentCard = A2ACardResolver.builder().baseUrl(SERVER_URL).build().getWellKnownAgentCard();
System.out.println("Successfully fetched public agent card:");
System.out.println(JsonUtil.toJson(publicAgentCard));
System.out.println("Using public agent card for client initialization (default).");
Expand Down
Loading