feat(ledger): replace yarn install with corepack for zemu test step#88
Open
chcmedeiros wants to merge 1 commit into
Open
feat(ledger): replace yarn install with corepack for zemu test step#88chcmedeiros wants to merge 1 commit into
chcmedeiros wants to merge 1 commit into
Conversation
Drop the global yarn install and rely on corepack so the pnpm version pinned by ledger-zxlib (PNPM_VERSION in dockerized_build.mk) can be activated dynamically. Unblocks migration to pnpm 11, whose stricter postinstall-script policy is the supply-chain reason for the switch. Breaking change for caller apps still on yarn — they need to bump zxlib to a pnpm-aware version, add tests_zemu/pnpm-workspace.yaml with the allowBuilds list, and replace yarn.lock with pnpm-lock.yaml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the global yarn install and rely on corepack to provision the package manager declared in each app's tests_zemu/package.json
packageManagerfield. Unblocks migration to pnpm 11, whose stricter postinstall-script policy is the supply-chain reason for the switch.Breaking change for caller apps still on yarn — they must add a
packageManagerpin and a pnpm lockfile before consuming this version.