Skip to content

fix: Attempt to fix github #1 (new tabs inherit iframe restrictions). #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jnms-me wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Attempt to fix github #1 (new tabs inherit iframe restrictions). #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35d1f4a
style(zapp-iframe): Add editorconfig.
jnms-me Feb 16, 2026
fa83d88
fix: Attempt to fix github #1 (new tabs inherit iframe restrictions).
jnms-me Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions example_iframe/zapp-iframe.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,9 @@ window.onmessage = function (e) {
opened = msg.state;
dropdown.style.visibility = opened ? "visible" : "hidden";
button.contentWindow.postMessage(msg, "*");
} else if (msg.type === "open-link") {
window.open(msg.url, '_blank').focus();
button.contentWindow.postMessage(msg, "*");
} else {
console.error("no supported msg type: " + msg.type);
}
Expand Down
9 changes: 9 additions & 0 deletions zapp-iframe/.editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
root = true

[*]
indent_style = tab
indent_size = 2
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true
6 changes: 5 additions & 1 deletion zapp-iframe/src/lib/components/Dropdown.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
'*'
);
}

const cookie = getCookie('zapp-labelson');
if(!cookie) labelson = true;
else labelson = cookie === "true";
Expand Down Expand Up @@ -173,6 +173,10 @@
class="w95in1 w-25 h-25 style absolute"
aria-label={app.img}
title={app.tooltip}
onclick={(event) => {
window.parent.postMessage(JSON.stringify({ type: 'open-link', url: app.url }), '*');
event.preventDefault();
}}
>
<div class="bborder bborder1">
<div class="bborder bborder2">
Expand Down