Fix: Share button not found on non-English browser locales#21
Open
blue-int wants to merge 1 commit intoZeroSharp:masterfrom
Open
Fix: Share button not found on non-English browser locales#21blue-int wants to merge 1 commit intoZeroSharp:masterfrom
blue-int wants to merge 1 commit intoZeroSharp:masterfrom
Conversation
f234bae to
138bfdf
Compare
The extension fails to find the Share button when the browser language is not English, because openShareDialog() relies on aria-label="Share" which chess.com localizes (e.g. "공유" in Korean). Add data-cy="sidebar-share-icon" as the primary selector, which is locale-independent and stable across UI updates. Also remove Chrome Web Store update_url from manifest.json, which Microsoft's porting guide requires for Edge compatibility.
138bfdf to
7026f20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update_urlfor Edge compatibilityProblem
openShareDialog()relies onbutton[aria-label="Share"], but chess.com localizesaria-labelbased on browser locale (e.g."공유"in Korean). All selectors miss.Changes
1. Locale-independent selector (
getpgn.js)Added
[data-cy="sidebar-share-icon"]as the first selector.data-cyis not localized:2. Remove
update_url(manifest.json)Removed
"update_url": "https://clients2.google.com/service/update2/crx"per Microsoft's porting guide.Test plan
[data-cy="sidebar-share-icon"]exists on chess.com game pages