update enforce_joint_model_state_space in config#157
update enforce_joint_model_state_space in config#157yifeifang wants to merge 2 commits intoZebraDevs:melodic-develfrom
Conversation
yifeifang
requested review from
a team and
zzhu-fetch
and removed request for
a team
|
Hi zzhu, |
|
Hi @yifeifang, sorry, our review process here does tend to be a bit slow. I need to review it as well but need to spend some time getting context/background (and need to find some spare time for that). @zzhu-fetch is pretty new here, so probably shouldn't have been assigned as a reviewer ;). One quick thought on my end: I think it would be better if the commented information in the diffs were instead in the git commit message. Does that sound reasonable to you, @yifeifang ? Lastly, when we do get a chance to merge this, we would probably also forward-port this change to the noetic branch |
|
Thanks for your reply! I think it's a good point and I will go ahead and move the comment in to git commit description |
This will enforce JointModelStateSpaceFactory for problem representing see moveit/moveit#541 for detail basically this would allow path constraints in moveit_commander to work properly
3 participants
I've encountered a problem where set_path_constraint in moveit commander with orientation constraint didn't really work (Sometimes it is still going out of the constraint). After a bit of research, I found this workaround in Moveit! See this pose for detail moveit/moveit#541. With this changes in the ompl_planner.yaml it will enforce it to choose store info in joint space which will make sure the set_path_constraint interface behaves as desired. See https://www.youtube.com/watch?v=kIy_dX4ovQM&ab_channel=%E6%96%B9%E6%98%93%E9%9D%9E this video for constrain in work.