feat(core/txpool): improve error responses #30715#2170
feat(core/txpool): improve error responses #30715#2170gzliudan wants to merge 1 commit intoXinFinOrg:dev-upgradefrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR improves transaction validation error reporting in the txpool by preserving the underlying sender-recovery failure reason instead of returning a generic ErrInvalidSender, making RPC/user-facing diagnostics more informative.
Changes:
- Wrap
ErrInvalidSenderwith the originaltypes.Sendererror to expose the concrete failure reason in the returned error string. - Preserve
errors.Is(err, ErrInvalidSender)semantics via%wwrapping.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Proposed changes
Ref: ethereum#30715
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which parts of the codebase does this PR touch?
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that