fix(core/txpool): clarify tx validation error messages #29081

[gzliudan]

Proposed changes

Adjust txpool validation error wording to report actual and minimum values consistently.

• intrinsic gas error now reports: gas , minimum needed

• underpriced tip error now reports: gas tip cap , minimum needed

No transaction validation logic is changed in this commit; only error message text is updated.

Ref: ethereum#29081

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Changes that don't change source code or tests
• docs: Documentation only changes
• feat: A new feature
• fix: A bug fix
• perf: A code change that improves performance
• [ X refactor: A code change that neither fixes a bug nor adds a feature
• revert: Revert something
• style: Changes that do not affect the meaning of the code
• test: Adding missing tests or correcting existing tests

Impacted Components

Which parts of the codebase does this PR touch?
Put an ✅ in the boxes that apply

• Consensus
• Account
• Network
• Geth
• Smart Contract
• External components
• Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

• This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
• Tested on a private network from the genesis block and monitored the chain operating correctly for multiple epochs.
• Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
• Tested the backwards compatibility.
• Tested with XDC nodes running this version co-exist with those running the previous version.
• Relevant documentation has been updated as part of this PR
• N/A

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 990e52ff-e5df-4b05-99e0-5dcb7436e84f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR standardizes the wording of transaction validation error messages in core/txpool/validation.go to consistently report the actual value first and the minimum required value second, using the format <field> <actual>, minimum needed <required>.

Changes:

• Reworded intrinsic gas error to report gas <actual>, minimum needed <required> (was needed <required>, allowed <actual>).
• Reworded underpriced tip errors (both for special transactions and normal transactions) to report gas tip cap <actual>, minimum needed <required> (was tip needed <required>, tip permitted <actual>).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.