fix(consensus): fix config object not reference to same one and concurrency issues and refactor access pattern

[benjamin202410]

refactor(consensus): fix config concurrency issues and refactor access pattern

• Return defensive copies of V2Config to prevent concurrent modification
• Add Config() method to XDPoS_v2 engine for centralized config access
• Update hooks to retrieve config through engine instead of chain config
• Use json.Decoder with UseNumber() in deepCloneJSON for safer JSON parsing
• Remove unnecessary return statement in saveRewardToFile

These changes prevent race conditions when accessing V2 configs from multiple
goroutines and establish a clearer separation of concerns by accessing
configuration through the consensus engine.

Changes:

• Added bytes import for bytes.NewReader
• Replaced json.Unmarshal with json.NewDecoder + UseNumber()
• Ensures numeric data integrity in consensus engine operations

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Changes that don't change source code or tests
• docs: Documentation only changes
• feat: A new feature
• fix: A bug fix
• perf: A code change that improves performance
• refactor: A code change that neither fixes a bug nor adds a feature
• revert: Revert something
• style: Changes that do not affect the meaning of the code
• test: Adding missing tests or correcting existing tests

Impacted Components

Which parts of the codebase does this PR touch?
Put an ✅ in the boxes that apply

• Consensus
• Account
• Network
• Geth
• Smart Contract
• External components
• Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

• This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
• Tested on a private network from the genesis block and monitored the chain operating correctly for multiple epochs.
• Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
• Tested the backwards compatibility.
• Tested with XDC nodes running this version co-exist with those running the previous version.
• Relevant documentation has been updated as part of this PR
• N/A

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6fc4b3c9-0f82-4a72-8209-3bfb94ceb72e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix(consensus)-preserve-numeric-precision-in-deepCloneJSON-using-json.Number

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR refactors the XDPoS consensus engine's configuration access patterns to improve thread safety and reduce coupling. It prevents potential race conditions when reading V2Config from multiple goroutines by returning defensive copies, centralizes config access through a new Config() method on XDPoS_v2, and uses json.Decoder with UseNumber() in deepCloneJSON to preserve numeric precision.

Changes:

• params/config.go: Both GetCurrentConfig() and Config(round) now return a value copy of the config struct instead of the original pointer, preventing callers from mutating shared config.
• consensus/XDPoS/engines/engine_v2/engine.go: Adds Config(r uint64) method as a centralized accessor, uses UseNumber() in deepCloneJSON, and removes an unnecessary return statement.
• eth/hooks/engine_v2_hooks.go: Updates HookPenalty and HookReward to retrieve config through the engine (via bc.Engine()) rather than directly from the chain config.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
params/config.go	Returns defensive copies of V2Config in Config() and GetCurrentConfig() to prevent shared mutation
consensus/XDPoS/engines/engine_v2/engine.go	Adds Config() method, uses json.Decoder+UseNumber() in deepCloneJSON, removes bare return
eth/hooks/engine_v2_hooks.go	Hooks now resolve config via bc.Engine() cast to *XDPoS.XDPoS rather than the chain config

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.