[WIP] refactor(consensus): split ChainReader interface #20692

[gzliudan]

Proposed changes

Ref: ethereum#20692

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)
• Regular KTLO or any of the maintaince work. e.g code style
• CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an ✅ in the boxes that apply

• Consensus
• Account
• Network
• Geth
• Smart Contract
• External components
• Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

• This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
• Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
• Tested the backwards compatibility.
• Tested with XDC nodes running this version co-exist with those running the previous version.
• Relevant documentation has been updated as part of this PR
• N/A

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This pull request refactors the consensus layer by splitting the ChainReader interface into two interfaces: ChainHeaderReader (header-only access) and ChainReader (extends ChainHeaderReader with full block access). This improves separation of concerns and makes it clearer when code needs full block access versus just header access.

Changes:

• Split ChainReader interface into ChainHeaderReader and ChainReader to separate header-only operations from full block access
• Updated all consensus engine methods to use ChainHeaderReader instead of ChainReader where full blocks are not needed
• Replaced chain.GetBlock() calls with rawdb.ReadBody() where appropriate when using ChainHeaderReader

Reviewed changes

Copilot reviewed 31 out of 31 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
consensus/consensus.go	Defines new ChainHeaderReader interface and makes ChainReader extend it
consensus/ethash/*.go	Updates ethash consensus engine to use ChainHeaderReader; adds type assertion in VerifyUncles for block access
consensus/clique/*.go	Updates clique consensus engine to use ChainHeaderReader throughout
consensus/XDPoS/**/*.go	Updates XDPoS v1 and v2 engines to use ChainHeaderReader; includes hooks and all engine methods
miner/*.go	Updates miner agents to use ChainHeaderReader
internal/ethapi/*.go	Updates API layer to use ChainHeaderReader
eth/hooks/*.go	Updates consensus hooks; uses bc.GetBlock() directly when block access needed
eth/util/util.go	Updates utility function to use ChainHeaderReader
contracts/utils.go	Uses rawdb.ReadBody() instead of chain.GetBlock() with proper nil checking
eth/bft/*.go	Updates BFT handler and tests to use ChainHeaderReader
core/chain_makers.go	Updates chain maker to use ChainHeaderReader

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.