chore: Enable most clang-tidy bugprone checks#6929
Merged
ximinez merged 12 commits intoXRPLF:developfrom Apr 14, 2026
Merged
Conversation
godexsoft
commented
Apr 13, 2026
|
|
||
| /** Replacement for std::thread that handles exceptions in unit tests. */ | ||
| class thread | ||
| class Thread |
Contributor
Author
There was a problem hiding this comment.
Note: 'thread' conflicted with an internal to 'boost' name and produced an error.
In any case identifier-naming check will later change all classes to CamelCase
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6929 +/- ##
=======================================
Coverage 81.6% 81.6%
=======================================
Files 1010 1010
Lines 75969 75972 +3
Branches 7625 7622 -3
=======================================
+ Hits 61983 61987 +4
+ Misses 13986 13985 -1
🚀 New features to boost your workflow:
|
mathbunnyru
reviewed
Apr 13, 2026
Contributor
mathbunnyru
left a comment
There was a problem hiding this comment.
Nothing major, a few comments
mathbunnyru
approved these changes
Apr 14, 2026
mvadari
reviewed
Apr 14, 2026
mvadari
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR enables the following clang-tidy checks:
Context of Change
Fixing remaining clang-tidy checks after adding headers to the list of checked files.
API Impact
No impact.