fix: issue 6847 default peering port to 2459

[shortthefomo]

only leave the correct default in place 2459 and not 51235

force the default port, the backwards compatibility is still present higher up in the config default file. This just forces lazy operators across.

default port was giving back in 2019 #3037

the definition is still provided higher up in the file

#   One address or domain name per line is allowed. A port may be specified
#   after adding a space to the address. If a port is not specified, the default
#   port of 2459 will be used. Many servers still use the legacy port of 51235.
#   To connect to such servers, you must specify the port number. The ordering
#   of entries does not generally matter.

fixes issue #6847

[github-actions]

⚠️ This PR contains unsigned commits. To get your PR merged, please sign them. ⚠️

If only the most recent commit is unsigned, you can run:

1. Amend the commit: git commit --amend --no-edit -n -S
2. Overwrite the commit: git push --force-with-lease

If multiple commits are unsigned, you can run:

1. Go into interactive rebase mode: git rebase --interactive HEAD~<NUM_OF_COMMITS>, where NUM_OF_COMMITS is the number of most recent commits that will be available to edit.
2. Change "pick" to "edit" for the commits you need to sign, and then save and exit.
3. For each commit, run: git commit --amend --no-edit -n -S
4. Continue the rebase: git rebase --continue
5. Overwrite the commit(s): git push --force-with-lease

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

1. Generate a GPG key
2. Add the GPG key to your GitHub account
3. Configure git to use your GPG key for commit signing

Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

1. Generate an SSH key and add it to ssh-agent
2. Add the SSH key to your GitHub account
3. Configure git to use your SSH key for commit signing

Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.
See use 1Password to sign your commits.

[legleux]

This is long overdue.

[legleux]

@bthomee how do you feel about the convention of leaving default items in config files commented out?

[bthomee]

@bthomee how do you feel about the convention of leaving default items in config files commented out?

That sounds reasonable to me, in principle. However, do we have any mechanism in place to guarantee that the values we think are the default (as stated in the config file) are actually the default (as executed by the code)?

[shortthefomo]

That sounds reasonable to me, in principle. However, do we have any mechanism in place to guarantee that the values we think are the default (as stated in the config file) are actually the default (as executed by the code)?

The [port_peer] section is purely user-configured — there's no fallback to DEFAULT_PEER_PORT if [port] is omitted (it would just fail to parse). The 2459 default only kicks in for [ips]/[ips_fixed] entries and the connect RPC when no port is specified.

By that view as well then one should default the whole stanza for [port_peer] ?