Extraction of settings access into own module#130
Open
leonsbane wants to merge 3 commits intoWintermute0110:release-0.9.x-python2from
leonsbane:feature/own_config_module
Open
Extraction of settings access into own module#130leonsbane wants to merge 3 commits intoWintermute0110:release-0.9.x-python2from leonsbane:feature/own_config_module
leonsbane wants to merge 3 commits intoWintermute0110:release-0.9.x-python2from
leonsbane:feature/own_config_module
Conversation
# Conflicts: # resources/main.py # resources/scrap.py
# Conflicts: # resources/main.py
Owner
|
Hi, Thanks for the effort you did in making this. I will not merge this yet. I am still thinking about the future of AEL, either to move to a pure functional approach like AML of continue the object oriented model currently in master. Please keep the PR for the time being. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
thank you very much for creating this addon.
The changes in this PR are refactoring the settings access from inside the code by creating a module which can be imported when needed.
I wanted to make the access somewhat more global and a bit safer. This also removes the necessity to pass the settings as an argument to other modules.
It's not fixing anything, but maybe you still might be interested.