entity activation: use kd-tree for players and dedup entities#528
Open
hayanesuru wants to merge 3 commits into
Open
entity activation: use kd-tree for players and dedup entities#528hayanesuru wants to merge 3 commits into
hayanesuru wants to merge 3 commits into
Conversation
hayanesuru
changed the title
hayanesuru
force-pushed
the
4-entity-activation
branch
from
4a3617e to
8990589
Compare
hayanesuru
changed the title
hayanesuru
added
type: feature
Dreeam-qwq
added
type: optimization
hayanesuru
force-pushed
the
4-entity-activation
branch
3 times, most recently
from
99c8a9c to
7e32352
Compare
3 tasks
hayanesuru
force-pushed
the
4-entity-activation
branch
from
7e32352 to
5f16578
Compare
Dreeam-qwq
requested changes
Apr 11, 2026
Member
Dreeam-qwq
left a comment
Dreeam-qwq
left a comment
There was a problem hiding this comment.
Since we added a more efficient activation range impl here, do we still need to optimize the original activation range impl?
And I think we don't need to build K-D Tree 3D if the dab is disabled.
hayanesuru
force-pushed
the
4-entity-activation
branch
from
d098e6e to
33ab76d
Compare
3 tasks
Dreeam-qwq
requested changes
May 8, 2026
| } | ||
|
|
||
| - return (int) Math.min(Integer.MAX_VALUE, Math.max(1, Math.round(wakeUpDuration * wakeUpDurationRandom.nextGaussian(1, deviation)))); | ||
| + return (int) Math.min(Integer.MAX_VALUE, Math.max(1, Math.round(wakeUpDuration * (1.0 + deviation * entity.random.nextGaussian())))); // Leaf - optimize entity activation |
Member
There was a problem hiding this comment.
It's better to move this change to the original patch Variable-entity-wake-up-duration.patch, since there is an existing patch in Leaf, no need to use another patch to make this kind of changes.
| : dx * dx + dy * dy; | ||
| } | ||
|
|
||
| public boolean isEmpty() { |
Member
There was a problem hiding this comment.
If it's a method that may be used in the future, you can add a comment to note that.
| + (dontEnableIfInWater || entity.getType().is(net.minecraft.tags.EntityTypeTags.CAN_BREATHE_UNDER_WATER) || !entity.isInWater())) { // Leaf - Option for dontEnableIfInWater | ||
| + int distSq = (int) player.distanceToSqr(entity); | ||
| + a = distSq > startSq ? | ||
| + Math.min(maxPriority, Math.max((int) (distSq * scale), 1)) : |
Member
There was a problem hiding this comment.
Any reason you changed original impl from "int + shift" to "double + scale"?
| - entity.activatedPriority = 1; | ||
| + a = 1; | ||
| } | ||
| + entity.activatedPriority = reset.add(entity.getId()) ? a : Math.min(a, entity.activatedPriority); |
Member
There was a problem hiding this comment.
Hmmmm, I think using IntOpenHashSet here is slower than using a boolean to handle the reset in the original impl?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.