Fix cont.wast func returning a cont ref to JS#138
Merged
fgmccabe merged 1 commit intoWebAssembly:mainfrom Mar 5, 2026
Merged
Conversation
The function "null-new" in cont.wast returns a cont ref, so when compiled to JavaScript, the function invocation results in a type error instead of the expected null dereference trap. Just drop the return, it is not relevant for this test.
fgmccabe
approved these changes
Mar 5, 2026
Collaborator
fgmccabe
left a comment
fgmccabe
left a comment
There was a problem hiding this comment.
Looks good to me.
We may also need a test that includes functions actually returning continuations.
tlively
reviewed
Mar 6, 2026
| (cont.new $k1 | ||
| (ref.null $f1) | ||
| ) | ||
| (unreachable) |
Member
There was a problem hiding this comment.
In general tools/engines other than the reference interpreter do not actually compare their error messages against the error messages in assert_trap assertions because it is expected that their error messages might be different. The trap from the unreachable here can therefore make the test appear to pass even if there is a bug that lets cont.new succeed without trapping. It would be better to use a drop instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function "null-new" in cont.wast returns a cont ref, so when compiled to JavaScript, the function invocation results in a type error instead of the expected null dereference trap. Just drop the return, it is not relevant for this test.