-
Notifications
You must be signed in to change notification settings - Fork 1
LeetCode 11: Container with most water #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # LeetCode 11. Container With Most Water | ||
| from typing import List | ||
|
|
||
|
|
||
| class Solution: | ||
| def maxArea(self, height: List[int]) -> int: | ||
| """ | ||
| Pseudocode: | ||
| The problem is we dont know the max area where we we can store most of the water | ||
| So we can store from the start to end of the container but if the starting height of container is 1 then | ||
| max we can store height of 1 as more then that will spile the water regardless the end height | ||
| so if len is 9 and height is 1 then container can contain Area = length × width | ||
|
|
||
| So, what we can do it use two pointer solution to find the max area | ||
| - initialize two pointer left and right, left with value of index 0 and | ||
| right index len(arr)-1 and res which contain most largest value | ||
| - we will continue until our left and right point cross their path | ||
| - we will be moving our smallest pointer as we know smallest length contain less water | ||
| - each time we will check which one is largest previous area which stored in res | ||
| - at the end we return the res as res will be containing the largest area value we got | ||
| """ | ||
| res = 0 | ||
| left, right = 0, len(height) - 1 | ||
| while left < right: | ||
| area = (right - left) * min(height[left], height[right]) | ||
| res = max(res, area) | ||
|
|
||
| if height[left] < height[right]: | ||
| left += 1 | ||
| else: | ||
| right -= 1 | ||
| return res | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix non-ASCII
×in docstring and optionally tighten wording.Ruff is flagging the
×character in"Area = length × width"as ambiguous; this can break linting/CI. Consider switching to plain ASCII (e.g.,length * widthorlength x width) and fixing a few typos for clarity.For example:
You could also rename
len(arr)in the comments tolen(height)to match the actual parameter name, but that’s purely cosmetic.📝 Committable suggestion
🧰 Tools
🪛 Ruff (0.14.7)
12-12: Docstring contains ambiguous
×(MULTIPLICATION SIGN). Did you meanx(LATIN SMALL LETTER X)?(RUF002)
🤖 Prompt for AI Agents