Gym defenders implementation

[sanderDijkxhoorn]

Implementing #1101

Latest design:

I made a little oopsy with the last PR... here is a cleaner version of the PR, no GitHub workflow commits.

[Mygod]

By the way the threshold numbers are definitely not one/two thirds. I think it's 73% or something similar.

[Mygod]

Yeah it's ~47% and then ~73% as the threshold, or more precisely, 7/15 and then 11/15. The minimum is 20% or 1/5.

See also: https://pogo.gamepress.gg/gym-motivation-what-you-should-know

[lenisko]

I made another small change (dropped defender info from extra text), including hearth thing @Mygod mentioned: sanderDijkxhoorn#3

[sanderDijkxhoorn]

I merged it, could someone try to run this PR and check if all functions correctly?

[lenisko]

@sanderDijkxhoorn I'm running it on prod at top of #1113. Everything looks good related to defenders.

[Mygod]

White stripes are not visible in light mode. 👀

[Mygod]

By the way, do we want to display some of these other fields? deployed_time,battles_won,battles_lost,times_fed

[lenisko]

By the way, do we want to display some of these other fields? deployed_time,battles_won,battles_lost,times_fed

Waste of space... Unless we would toggle ON CLICK between Pokemon name & CP line and something like:

:mdiMedal: {battles_won} :mdiEmoticonSad: {battles_lost} :mdiFoodApple: {times_fed}
{deployed_time}

[Mygod]

I guess if people are okay with it, I will merge and implement the changes myself.

[Mygod]

Looks fucking good. UI done by vibe coding. @sanderDijkxhoorn @lenisko Merge?

[sanderDijkxhoorn]

Looks fucking good. UI done by vibe coding. @sanderDijkxhoorn @lenisko Merge?

Those icons look a little odd, replace it with berry and such?

Why does the top one start with 1d xxxx
The others have some hour minute seconds?

[Mygod]

Minor complaints about UI will be only accepted in the form of commits or PRs. :)

[github-actions]

🎉 This PR is included in version 1.36.0-develop.19 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[lenisko]

@Mygod this looks like a 💩 We just literary been fighting for any vertical space, and you just added a bunch of useless stuff on the same page.

That's why I proposed additional data on toggle/click.

[Mygod]

@lenisko I just care about functionality. If you want to make it look less 💩, PR welcome. :)

[github-actions]

🎉 This PR is included in version 1.36.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀