Skip to content

operator/deployment: replace httpGet probes with tcpSocket#1966

Open
sudharsans wants to merge 1 commit intoVictoriaMetrics:masterfrom
sudharsans:operator/use-tcp-health-probes
Open

operator/deployment: replace httpGet probes with tcpSocket#1966
sudharsans wants to merge 1 commit intoVictoriaMetrics:masterfrom
sudharsans:operator/use-tcp-health-probes

Conversation

@sudharsans
Copy link

@sudharsans sudharsans commented Mar 15, 2026

What

Replace livenessProbe and readinessProbe httpGet actions with tcpSocket in the operator deployment manifest.

Why

The current httpGet probes fail when the health-probe server is served over TLS, because the kubelet sends a plain HTTP request.

tcpSocket probes only check that the port is accepting connections — agnostic to HTTP vs HTTPS — so they work correctly for both configurations.

Fixes #1824


Summary by cubic

Replace the operator deployment’s liveness/readiness httpGet probes with tcpSocket so health checks work over both HTTP and HTTPS. Fixes #1824 by avoiding plain-HTTP requests against TLS health endpoints.

Written for commit a207047. Summary will update on new commits.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files


Since this is your first cubic review, here's how it works:

  • cubic automatically reviews your code and comments on bugs and improvements
  • Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
  • Add one-off context when rerunning by tagging @cubic-dev-ai with guidance or docs links (including llms.txt)
  • Ask questions if you need clarification on any suggestion

@AndrewChubatiuk
Copy link
Contributor

AndrewChubatiuk commented Mar 15, 2026

#1824 was related to CR probes, not operator ones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add TCP startup checks

3 participants