operator/deployment: replace httpGet probes with tcpSocket#1966
Open
sudharsans wants to merge 1 commit intoVictoriaMetrics:masterfrom
Open
operator/deployment: replace httpGet probes with tcpSocket#1966sudharsans wants to merge 1 commit intoVictoriaMetrics:masterfrom
sudharsans wants to merge 1 commit intoVictoriaMetrics:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
No issues found across 2 files
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Contributor
|
#1824 was related to CR probes, not operator ones |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace
livenessProbeandreadinessProbehttpGetactions withtcpSocketin the operator deployment manifest.Why
The current
httpGetprobes fail when the health-probe server is served over TLS, because the kubelet sends a plain HTTP request.tcpSocketprobes only check that the port is accepting connections — agnostic to HTTP vs HTTPS — so they work correctly for both configurations.Fixes #1824
Summary by cubic
Replace the operator deployment’s liveness/readiness
httpGetprobes withtcpSocketso health checks work over both HTTP and HTTPS. Fixes #1824 by avoiding plain-HTTP requests against TLS health endpoints.Written for commit a207047. Summary will update on new commits.