Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Haleygo
reviewed
Mar 3, 2026
Member
Haleygo
left a comment
Haleygo
left a comment
There was a problem hiding this comment.
Nit: should we forbid using extraStorageNodes and extraArgs.storageNode together? A user might accidentally set both and get duplicate settings.
vrutkovs
reviewed
Mar 3, 2026
| } | ||
| if len(cr.Spec.VLSelect.ExtraStorageNodes) > 0 { | ||
| for i, node := range cr.Spec.VLSelect.ExtraStorageNodes { | ||
| idx := i + len(storageNodeIds) |
Collaborator
There was a problem hiding this comment.
Perhaps we should deduplicate the list? Users may accidentally set the same node twice.
Also, needs tests
Contributor
Author
There was a problem hiding this comment.
throwing error in case of duplicates instead since also per storage auth can be added and deduplication can break an order
…rage is not enabled
AndrewChubatiuk
force-pushed
the
fix-extra-storage-node-when-no-storage
branch
from
281ae15 to
f0dfa99
Compare
Signed-off-by: Vadim Rutkovsky <vadim@vrutkovs.eu>
vrutkovs
approved these changes
Mar 30, 2026
Signed-off-by: Vadim Rutkovsky <vadim@vrutkovs.eu>
AndrewChubatiuk
added a commit
that referenced
this pull request
Mar 31, 2026
…rage is not enabled (#1911) Co-authored-by: Vadim Rutkovsky <vadim@vrutkovs.eu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1910
Summary by cubic
Fixes VLSelect and VTSelect ignoring ExtraStorageNodes when default storage is disabled, so select pods connect to the provided storage nodes. Also validates and rejects duplicate storageNode addresses across defaults and extras (fixes #1910).
-storageNodeflag and collect node IDs outside the default-storage check.-storageNodeonly when nodes exist; always includeExtraStorageNodeseven without default storage.ExtraArgs["storageNode"], andExtraStorageNodes.Written for commit de3e677. Summary will update on new commits.