fix: null message crash and drop array messages#51
Merged
na-ji merged 2 commits intoUnownHash:mainfrom Mar 24, 2025
Flechaa:fix-null-crash
Merged
fix: null message crash and drop array messages#51na-ji merged 2 commits intoUnownHash:mainfrom Flechaa:fix-null-crash
na-ji merged 2 commits intoUnownHash:mainfrom
Flechaa:fix-null-crash
Conversation
na-ji
approved these changes
Mar 24, 2025
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously in PR #48, all JSON releated crashes were supposed to be fixed, however I completely missed out that
typeofdoesn't catch things like null in JSON since they are considered anobjectin JavaScript.Also arrays are not used for messages in Rotom so those were also checked and dropped in this PR.
Snippet that replicates the crash: