Skip to content

Stop spamming Look Rotation log when holding shift #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmcduff-unity wants to merge 4 commits into
base: master
Choose a base branch
from
+9 −3
Open

Stop spamming Look Rotation log when holding shift #653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b2f49df
Stop spamming LookRotation log
jmcduff-unity Feb 17, 2026
6df2035
Add changelog entry
jmcduff-unity Feb 17, 2026
6165917
Fix changelog entry
jmcduff-unity Feb 18, 2026
45c3671
Improve zero magnitude check and apply fix to other instance
jmcduff-unity Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## Unreleased

### Fixed

- [UUM-133861] Fixed "Look rotation viewing vector is zero" log being spammed when holding shift while using a create tool such as Create Sprite.

## [6.0.9] - 2026-01-30

### Fixed
Expand Down
6 changes: 3 additions & 3 deletions Editor/EditorCore/DrawShapeTool.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -868,7 +868,7 @@ internal void DoDuplicateShapePreviewHandle(Vector3 position)

m_Bounds.center = cornerPosition + new Vector3(size.x / 2f, 0, size.z / 2f) + (size.y / 2f) * m_Plane.normal;
var lastPreviewRotation = m_PlaneRotation;
m_PlaneRotation = Quaternion.LookRotation(m_PlaneForward, m_Plane.normal);
m_PlaneRotation = Mathf.Approximately(m_PlaneForward.sqrMagnitude, 0f) ? Quaternion.identity : Quaternion.LookRotation(m_PlaneForward, m_Plane.normal);
var forceRebuildPreview = !m_PlaneRotation.Equals(lastPreviewRotation) ||
m_LastPreviewPivotLocation != pivotLocation;
m_LastPreviewPivotLocation = pivotLocation;
Expand Down Expand Up @@ -919,7 +919,7 @@ internal void DoDuplicateShapePreviewHandle(Vector3 position)
pivot += .5f * size.y * m_Plane.normal;
else
pivot = previewPivotPosition;
m_DuplicateGO.transform.SetPositionAndRotation(pivot, Quaternion.LookRotation(m_PlaneForward, m_Plane.normal));
m_DuplicateGO.transform.SetPositionAndRotation(pivot, m_PlaneRotation);

DrawBoundingBox(preview_BB_Origin, preview_BB_HeightCorner, preview_BB_OppositeCorner, false);
}
Expand All @@ -943,7 +943,7 @@ void RecalculateBounds()
if(Mathf.Abs(m_Bounds.center.y) < 0.0001f)
m_Bounds.center = m_Bounds.center + 0.0001f * Vector3.up;

m_PlaneRotation = Quaternion.LookRotation(m_PlaneForward,m_Plane.normal);
m_PlaneRotation = Mathf.Approximately(m_PlaneForward.sqrMagnitude, 0f) ? Quaternion.identity : Quaternion.LookRotation(m_PlaneForward, m_Plane.normal);
}

internal void RebuildShape()
Expand Down