docs: add simulation failures and settlement guide for priority orders (PROTO-1329)#1131
Draft
pinky-gh[bot] wants to merge 1 commit into
Draft
docs: add simulation failures and settlement guide for priority orders (PROTO-1329)#1131pinky-gh[bot] wants to merge 1 commit into
pinky-gh[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a new guide at
docs/contracts/uniswapx/fillers/priority/simulation-and-settlement.mdcovering:Also updates
filleroverview.mdwith a cross-link to the new guide.Why
Priority order fillers have been encountering confusing simulation failures due to block-timing sensitivity. This guide gives fillers the context they need to distinguish expected reverts from genuine errors, and prescribes the correct retry/skip behavior to avoid missed fills and unnecessary gas spend.