Conversation
…o iterate over h3 again to get the link
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/UCSBCarpentry/web-scraping-python/compare/md-outputs..md-outputs-PR-3 The following changes were observed in the rendered markdown documents: What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2026-01-26 19:56:45 +0000 |
|
Ok, I did some reviewing and undid some of the changes you made:
I'll add my comments on selectors after this |
|
Ok, now on the selectors section. (Seeing Selenium and Playwright documentation I noticed they started calling it
|
|
I'll merge this PR for the corrections to be ready for our workshop tomorrow, but opening a new issue to continue talking more about the pending topics |
Auto-generated via `{sandpaper}`
Source : 43b6d7a
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2026-01-27 00:24:41 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : eebb572
Branch : main
Author : Jose Niño <72319858+josenino95@users.noreply.github.com>
Time : 2026-01-27 00:24:05 +0000
Message : Merge pull request #3 from jairomelo/realwebsite
Realwebsite
Auto-generated via `{sandpaper}`
Source : 43b6d7a
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2026-01-27 00:24:41 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : eebb572
Branch : main
Author : Jose Niño <72319858+josenino95@users.noreply.github.com>
Time : 2026-01-27 00:24:05 +0000
Message : Merge pull request #3 from jairomelo/realwebsite
Realwebsite
Auto-generated via `{sandpaper}`
Source : 43b6d7a
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2026-01-27 00:24:41 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : eebb572
Branch : main
Author : Jose Niño <72319858+josenino95@users.noreply.github.com>
Time : 2026-01-27 00:24:05 +0000
Message : Merge pull request #3 from jairomelo/realwebsite
Realwebsite
I struggled to find a natural 'landing spot' for the CSS-HTML relation and the concept of selectors, primarily because selectors aren't explicitly used in the current lesson examples. I’m also hesitant to link selectors strictly to CSS, as they are a broader mechanism used by JS and other tools to target elements.
However, I’ve updated the chapter outputs and fixed the anchor href retrieval logic.
If anyone has a suggestion for where the CSS/Selector concept fits best without feeling forced, I’m open to ideas!