Skip to content

Network should not be forced available #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chemaclass merged 2 commits into from
Jan 27, 2026
Merged

Network should not be forced available #583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd0f69b
fix: handle no-network gracefully in install_test.sh
Chemaclass Jan 27, 2026
711a460
docs: update changelog for issue #582
Chemaclass Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@
- Useful for CI/CD pipelines or log-restricted environments
- Can also be set via `BASHUNIT_NO_PROGRESS=true` environment variable

### Fixed
- Self-test `tests/acceptance/install_test.sh` now passes when no network tools are available (Issue #582)
- Tests skip gracefully with `BASHUNIT_NO_NETWORK=true` or in sandboxed environments

## [0.32.0](https://github.com/TypedDevs/bashunit/compare/0.31.0...0.32.0) - 2026-01-12

### Changed
Expand Down
7 changes: 5 additions & 2 deletions tests/acceptance/install_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,11 @@ HAS_DOWNLOADER=0
HAS_GIT=0

function set_up_before_script() {
bashunit::env::active_internet_connection
ACTIVE_INTERNET=$?
if bashunit::env::active_internet_connection; then
ACTIVE_INTERNET=0
else
ACTIVE_INTERNET=1
fi
if bashunit::dependencies::has_curl || bashunit::dependencies::has_wget; then
HAS_DOWNLOADER=1
fi
Expand Down
Loading