Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: Add Testing Suite Infrastructure
Summary of Changes
pytestandpytest-mock.fee_adjuster.py(focusing on the recent "stuck channel" fix).Magma/magma_sale_process.py(focusing on order handling and LND integration).fee_adjuster.md) with testing instructions.Detailed Changes
requirements-dev.txt: Addedpytest,pytest-mock,requests-mock.tests/conftest.py: Added shared fixtures for fee configuration..github/workflows/tests.yml: New CI workflow.tests/test_fee_adjuster.py.accept_order,reject_order,execute_lnd_command, andexecute_lncli_addinvoiceviatests/Magma/test_magma_sale_process.py.sys.modulespatching to mock global side-effects (telebot, configparser).Testing Strategy
What's Left for Later
LNDg/scripts (e.g.,amboss_pull.py,channel_base-fee.py).Checklist