Open
Conversation
…and adjust the cross entropy calculation to ignore masked (padding) tokens.
Contributor
Author
|
Bump @bryce13950 |
Collaborator
|
Sorry for the delay on getting this in, and thanks for bumping me. I updated it to the most recent version of TransformerLens, and that seems to have caused some issues. I am thinking of rolling this into 3.0. The issues that came up, I believe will already be fixed in dev-3.x. If you are fine with that, I will update the merge point to dev-3.x and work this into 3.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I think that all libraries are supposed to include a py.typed file for types to be accessible to external users. See: https://blog.whtsky.me/tech/2021/dont-forget-py.typed-for-your-typed-python-package/.
However, I haven't researched this thoroughly, so someone should probably look into this a bit more.
Type of change
Checklist: