Conversation
Fixed the compiler errors as requested by Will. There's then a make error, but one step at a time .... make: *** [test/wavfilt.chk] Error 1
wkearn
left a comment
wkearn
left a comment
There was a problem hiding this comment.
There's then a make error, but one step at a time ....
make: *** [test/wavfilt.chk] Error 1
Do you get this error when you run your current code? I don't see it when I run it on my machine, and it is not showing up in our automated checks. Perhaps there are some platform-specific discrepancies (possibly floating point arithmetic differences) that we need to be checking for.
Do you see any additional output from make? There should also be a diff output from the failed test.
Otherwise, we just need to stop tracking the output files, see the comment here: https://github.com/TopoToolbox/SWT/pull/8/changes#r2946271913
There was a problem hiding this comment.
I don't want to track these output files -- this one and test/seamounts_output.txt -- because they are large and have progress and debug information rather than just data. I think I added test/output.txt by mistake earlier. Can you run
git rm test/seamounts_output.txt
and
git rm test/output.txt
to stop tracking these two files, then make a new commit on the same branch and push back to GitHub?
2 participants
Fixed the compiler errors as requested by Will.
There's then a make error, but one step at a time ....
make: *** [test/wavfilt.chk] Error 1