Use UI.WPF.Modern to Implement Modern UI Design with Dark Mode Support#648
Closed
Jack251970 wants to merge 18 commits intoTichau:integrationfrom
Closed
Use UI.WPF.Modern to Implement Modern UI Design with Dark Mode Support#648Jack251970 wants to merge 18 commits intoTichau:integrationfrom
Jack251970 wants to merge 18 commits intoTichau:integrationfrom
Conversation
Modified CheckBox bindings in ConversionPresetTemplates.xaml: - Removed `IsEnabled` bindings for two CheckBox elements. - Updated `IsChecked` binding to use `Mode=TwoWay` for one CheckBox. - Added `Margin="0,6,0,0"` to one CheckBox for improved layout.
Replaced DockPanel with a horizontally oriented StackPanel for audio settings at Grid.Row="5" and Grid.Column="0". Moved the CheckBox and Label elements into the new StackPanel for improved layout consistency. Updated the Label's VerticalAlignment to Center for better alignment. No functional changes were made to bindings or converters.
There was a problem hiding this comment.
Pull request overview
This pull request implements modern UI design with dark mode support by integrating the iNKORE.UI.WPF.Modern library (version 0.10.1) into the FileConverter application. The changes resolve issue #240, which requested dark mode functionality.
Changes:
- Integrated UI.WPF.Modern library to provide modern UI styling with theme-aware dark mode support
- Updated all window XAML files with modern window styling attributes including Mica backdrop effects
- Refactored color references and styles to work dynamically with both light and dark themes
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| FileConverter.csproj | Added iNKORE.UI.WPF.Modern package dependency; removed Microsoft.Xaml.Behaviors.Wpf |
| Product.wxs | Updated installer components to include new UI.WPF.Modern DLLs; removed old Microsoft.Xaml.Behaviors entry |
| Application.xaml | Added UI.WPF.Modern theme resources and overrides for checkbox minimum width |
| MainWindow.xaml | Added modern window styling attributes and adjusted margins for new theme |
| SettingsWindow.xaml | Added modern styling with extended title bar, ScrollViewerEx for better scrolling, and layout improvements |
| UpgradeWindow.xaml | Added modern window styling and margin adjustments |
| HelpWindow.xaml | Added modern window styling with SizeToContent support and button stretch |
| DiagnosticsWindow.xaml | Added modern window styling and margin adjustments |
| CustomStyles.xaml | Commented out conflicting default styles; updated resource references to use theme-aware brushes |
| ConversionPresetTemplates.xaml | Updated color references to theme-aware resources; improved layouts for dark mode compatibility |
| ConversionJobControl.xaml | Adjusted foreground opacity values for better contrast across themes |
| EncodingQualitySliderControl.xaml | Updated color reference to theme-aware HyperlinkForeground brush |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #240