Skip to content

fix(Highlighter): fix highlighter clear not working correctly with filter#719

Open
9inpachi wants to merge 1 commit intoThatOpen:mainfrom
9inpachi:fix/highlighter-clear
Open

fix(Highlighter): fix highlighter clear not working correctly with filter#719
9inpachi wants to merge 1 commit intoThatOpen:mainfrom
9inpachi:fix/highlighter-clear

Conversation

@9inpachi
Copy link
Copy Markdown

Description

The Highlighter.clear has a bug because of which the filter parameter is not applied. The issue is with the Highlighter.selection[highlightName] getting reset which causes the full selection to be cleared even though the consumer may only want to clear the passed filter.

This PR fixes that issue by removing only the items to be cleared from Highlighter.selection[highlightName] and not fully resetting it.

Additional context

N/A


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following:

  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Follow the Conventional Commits v1.0.0 standard for PR naming (e.g. feat(examples): add hello-world example).
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant