fix(Highlighter): fix highlighter clear not working correctly with filter#719
Open
9inpachi wants to merge 1 commit intoThatOpen:mainfrom
Open
fix(Highlighter): fix highlighter clear not working correctly with filter#7199inpachi wants to merge 1 commit intoThatOpen:mainfrom
9inpachi wants to merge 1 commit intoThatOpen:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
Highlighter.clearhas a bug because of which thefilterparameter is not applied. The issue is with theHighlighter.selection[highlightName]getting reset which causes the full selection to be cleared even though the consumer may only want to clear the passedfilter.This PR fixes that issue by removing only the items to be cleared from
Highlighter.selection[highlightName]and not fully resetting it.Additional context
N/A
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following:
feat(examples): add hello-world example).fixes #123).