Enhanced code by means of C# 6#44
Open
AlexArchive wants to merge 6 commits intoTestStack:masterfrom
AlexArchive:master
Open
Enhanced code by means of C# 6#44AlexArchive wants to merge 6 commits intoTestStack:masterfrom AlexArchive:master
AlexArchive wants to merge 6 commits intoTestStack:masterfrom
AlexArchive:master
Conversation
Resharper does not work with Visual Studio 2015 Preview on Windows 10 at the moment. This is the best I can do on my machine. You should still be able to use other test runners. We can delete this commit later on.
Contributor
Author
|
Hold the phone. The string interpolation syntax is reportedly going to change soon. Expression-bodied members |
Contributor
Author
|
Preliminary implementation of #43 (Linking issues and pull request.) |
Member
|
Sorry for late reply. It's cool to see this. Definitely think it's too early to merge I'm afraid - it would stop most people from contributing since most people don't have VS 2015 installed. We need to install the right compiler on the CI server too (although that's easy enough). |
Contributor
Author
|
No worries man - I totally agree! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I manually went through each class in the main project and judiciously applied the following features of C# 6:
We can apply the other new features of C# 6 opportunistically.
In order to build the solution you will need to use Visual Studio 2015.
In order to run the tests, you may need to install the NUnit Test Adapter and run the tests using the Visual Studio test runner - they all pass 😄
I tried to be judicious but I suspect that I might have impaired readability in some cases due to my keenness to apply the new features. A fresh pair of eyes would be greatly appreciated - I am totally open to constructive criticism.
If you want to hold off from merging this into the main branch for a while, I do not mind one bit. I appreciate that this is a little bit premature. I am just happy to have had the opportunity to apply some of the new features.
I am so thankful for regression tests right about now 🍺