feat: upgrade django 5.2 in blue-krill#275
Open
xogas wants to merge 6 commits into
Open
Conversation
narasux
reviewed
May 13, 2026
| fail-fast: false | ||
| matrix: | ||
| python-version: ["3.9", "3.10", "3.11"] | ||
| python-version: ["3.11", "3.12"] |
narasux
reviewed
May 13, 2026
| return self.get_prep_value(value) | ||
|
|
||
| def from_db_value(self, value, expression, connection, context=None): | ||
| def from_db_value(self, value, expression, connection): |
Collaborator
There was a problem hiding this comment.
这里是新的 Django 设计中，不再需要支持 context 参数么
narasux
reviewed
May 13, 2026
| for cp in self.hosts: | ||
| host, port = cp["host"], cp["port"] | ||
| if not isinstance(host, str) or not isinstance(port, int): | ||
| raise TypeError(f"Invalid sentinel endpoint: missing host or port, got host={host!r}, port={port!r}") |
Collaborator
There was a problem hiding this comment.
这里好像不是检查 miss？而是检查类型，那么上面是不是应该用的 cp.get("host"), cp.get("port")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.