Skip to content

Mumble fixes #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sjrc6 merged 3 commits into from
Feb 28, 2026
Merged

Mumble fixes #189

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63f7ffb
Scale 2D space (for usable defaults in Mumble)
kaitlynia Feb 26, 2026
d913bb1
Forgot to make 2D_SCALE a float
kaitlynia Feb 26, 2026
c54bf4c
Fix typo (not correctly setting identity)
kaitlynia Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/game/client/components/tclient/mumble.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@

#include <game/client/gameclient.h>

#define MUMBLE_2D_SCALE 128.0f

void CMumble::MakeContext()
{
mumble_destroy_context(&m_pContext);
Expand Down Expand Up @@ -71,12 +73,12 @@ void CMumble::OnRender()
{
char aIdentity[16];
str_format(aIdentity, sizeof(aIdentity), "%d", ClientId);
if(!mumble_set_context(m_pContext, aIdentity))
if(!mumble_set_identity(m_pContext, aIdentity))
log_error("mumble", "Failed to set identity");
m_LastClientId = ClientId;
}
const auto &Pos = GameClient()->m_aClients[ClientId].m_RenderPos;
mumble_2d_update(m_pContext, Pos.x, Pos.y);
mumble_2d_update(m_pContext, Pos.x / MUMBLE_2D_SCALE, Pos.y / MUMBLE_2D_SCALE);
}

void CMumble::OnConsoleInit()
Expand Down
Loading