Skip to content

Conversation

@jmfrancois
Copy link
Contributor

@jmfrancois jmfrancois commented Jan 16, 2026

What is the problem this PR is trying to solve?

We want our code base to run out of the box with tools like vite, vitest.
We have merged a bunch of changes but no consumer.

What is the chosen solution to this problem?

Move to storybook 10 with vite will be our first consumer and test of this assumption.
This PR contains all the needed fix at the components level.
We have dropped a package from the code base as not maintained anymore.

so if you were using:

  • talend-scripts start (in a lib)
  • talend-scripts start-storybook
  • talend-scripts build-storybook

Those do not exists anymore.
You should remove update your dependency and conifguration.

TODO: write this in the changelog !

Please check if the PR fulfills these requirements

  • The PR have used yarn changeset to a request a release from the CI if wanted.
  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features) And non reg done before need review
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

@changeset-bot
Copy link

changeset-bot bot commented Jan 16, 2026

🦋 Changeset detected

Latest commit: 3100e35

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 21 packages
Name Type
@talend/react-faceted-search Major
@talend/react-components Major
@talend/react-forms Major
@talend/icons Major
@talend/scripts-core Major
@talend/react-containers Major
@talend/react-storybook-cmf Major
@talend/react-cmf Patch
@talend/scripts-config-storybook-lib Major
@talend/design-docs Minor
@talend/design-system Major
@talend/storybook-docs Major
@talend/ui-storybook-one Patch
@talend/eslint-config Major
@talend/scripts-config-typescript Major
@talend/react-faceted-search-query-client Major
@talend/ui-playground-vite Patch
@talend/ui-playground Patch
@talend/react-dataviz Patch
@talend/react-stepper Patch
@talend/scripts-config-react-webpack Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment on lines +13 to +14
- "start": "talend-scripts start"
+ "start": "storybook dev"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only true for a lib, an app would want to keep its start script as it is and update whatever the storybook app

@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe January 28, 2026 12:55 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe January 28, 2026 12:55 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe January 28, 2026 12:55 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe January 28, 2026 12:55 — with GitHub Actions Inactive
@franck-boncler2 franck-boncler2 merged commit ecbfee8 into master Jan 28, 2026
11 checks passed
@franck-boncler2 franck-boncler2 deleted the jmfrancois/chore/update-storybook branch January 28, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants