-
Notifications
You must be signed in to change notification settings - Fork 53
chore: storybook 10 #5675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: storybook 10 #5675
Conversation
🦋 Changeset detectedLatest commit: 3100e35 The changes in this PR will be included in the next version bump. This PR includes changesets to release 21 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| - "start": "talend-scripts start" | ||
| + "start": "storybook dev" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only true for a lib, an app would want to keep its start script as it is and update whatever the storybook app
What is the problem this PR is trying to solve?
We want our code base to run out of the box with tools like vite, vitest.
We have merged a bunch of changes but no consumer.
What is the chosen solution to this problem?
Move to storybook 10 with vite will be our first consumer and test of this assumption.
This PR contains all the needed fix at the components level.
We have dropped a package from the code base as not maintained anymore.
so if you were using:
Those do not exists anymore.
You should remove update your dependency and conifguration.
TODO: write this in the changelog !
Please check if the PR fulfills these requirements
yarn changesetto a request a release from the CI if wanted.[ ] This PR introduces a breaking change