Skip to content

Waveshare GEEK PSRAM fix#504

Merged
KenVanHoeylandt merged 1 commit intoTactilityProject:mainfrom
Shadowtrance:waveshare-geek-fix
Feb 15, 2026
Merged

Waveshare GEEK PSRAM fix#504
KenVanHoeylandt merged 1 commit intoTactilityProject:mainfrom
Shadowtrance:waveshare-geek-fix

Conversation

@Shadowtrance
Copy link
Contributor

@Shadowtrance Shadowtrance commented Feb 15, 2026

Summary by CodeRabbit

  • Chores
    • Updated device configuration settings for the Waveshare ESP32-S3 Geek to optimize memory management.

@coderabbitai
Copy link

coderabbitai bot commented Feb 15, 2026

📝 Walkthrough

Walkthrough

A new [sdkconfig] section is added to the device.properties file for the Waveshare ESP32-S3 Geek device. Three PSRAM-related configuration options are introduced: CONFIG_SPIRAM_FETCH_INSTRUCTIONS, CONFIG_SPIRAM_RODATA, and CONFIG_SPIRAM_XIP_FROM_PSRAM, all set to 'n'. These configurations address a boot-time PSRAM space issue. The change consists of 6 new lines with no modifications to existing content.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Waveshare GEEK PSRAM fix' directly and specifically describes the main change: addressing a PSRAM-related issue for the Waveshare ESP32-S3 GEEK device by adding three PSRAM configuration options to disable certain features.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@KenVanHoeylandt
Copy link
Contributor

Thanks a lot!

@KenVanHoeylandt KenVanHoeylandt merged commit 72b55b2 into TactilityProject:main Feb 15, 2026
53 checks passed
@Shadowtrance Shadowtrance deleted the waveshare-geek-fix branch February 15, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants