Rename icons, fix T-Lora Pager config and more

[KenVanHoeylandt]

Summary by CodeRabbit

• New Features

  • Added NFC chip-select to SD card hardware configuration.

• Refactor

  • Consolidated and renamed icon resources; apps and status-bar now reference unified icon headers and new icon constants.
  • Renamed LVGL lock API (timed → lvgl_try_lock) and updated callers.

• Documentation

  • Updated module README and license files; added Apache-2.0 license document.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR replaces LVGL symbol macros (LVGL_SYMBOL_) with LVGL_ICON_ variants and moves them into new headers: lvgl_icon_shared.h, lvgl_icon_statusbar.h, and lvgl_icon_launcher.h, deleting the old lvgl_symbols_* headers. The icon-generation script parameter and generated filenames/macros were renamed. Source files throughout apps and services were updated to include and use the new icon macros. Additional changes: an NFC CS pin was added to SdCard configuration, lvgl_try_lock_timed was renamed to lvgl_try_lock (with symbol table updates), and licensing/README files were modified (Apache license added, GPL file removed).

🚥 Pre-merge checks | ✅ 2 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 3.70% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Merge Conflict Detection	⚠️ Warning	❌ Merge conflicts detected (39 files): ⚔️ Devices/lilygo-tlora-pager/Source/devices/SdCard.cpp (content) ⚔️ Devices/waveshare-esp32-s3-geek/device.properties (content) ⚔️ Modules/hal-device-module/README.md (content) ⚔️ Modules/lvgl-module/README.md (content) ⚔️ Modules/lvgl-module/assets/generate-all.py (content) ⚔️ Modules/lvgl-module/include/tactility/lvgl_fonts.h (content) ⚔️ Modules/lvgl-module/include/tactility/lvgl_module.h (content) ⚔️ Modules/lvgl-module/source/arch/lvgl_esp32.c (content) ⚔️ Modules/lvgl-module/source/arch/lvgl_posix.c (content) ⚔️ Modules/lvgl-module/source/lvgl_fonts.c (content) ⚔️ Modules/lvgl-module/source/module.c (content) ⚔️ Modules/lvgl-module/source/symbols.c (content) ⚔️ Tactility/Source/app/addgps/AddGps.cpp (content) ⚔️ Tactility/Source/app/apphub/AppHubApp.cpp (content) ⚔️ Tactility/Source/app/applist/AppList.cpp (content) ⚔️ Tactility/Source/app/appsettings/AppSettings.cpp (content) ⚔️ Tactility/Source/app/chat/ChatApp.cpp (content) ⚔️ Tactility/Source/app/development/Development.cpp (content) ⚔️ Tactility/Source/app/display/Display.cpp (content) ⚔️ Tactility/Source/app/gpssettings/GpsSettings.cpp (content) ⚔️ Tactility/Source/app/i2cscanner/I2cScanner.cpp (content) ⚔️ Tactility/Source/app/keyboard/KeyboardSettings.cpp (content) ⚔️ Tactility/Source/app/launcher/Launcher.cpp (content) ⚔️ Tactility/Source/app/localesettings/LocaleSettings.cpp (content) ⚔️ Tactility/Source/app/notes/Notes.cpp (content) ⚔️ Tactility/Source/app/power/Power.cpp (content) ⚔️ Tactility/Source/app/screenshot/Screenshot.cpp (content) ⚔️ Tactility/Source/app/settings/Settings.cpp (content) ⚔️ Tactility/Source/app/systeminfo/SystemInfo.cpp (content) ⚔️ Tactility/Source/app/timedatesettings/TimeDateSettings.cpp (content) ⚔️ Tactility/Source/app/timezone/TimeZone.cpp (content) ⚔️ Tactility/Source/app/trackball/TrackballSettings.cpp (content) ⚔️ Tactility/Source/app/usbsettings/UsbSettings.cpp (content) ⚔️ Tactility/Source/app/webserversettings/WebServerSettings.cpp (content) ⚔️ Tactility/Source/app/wifimanage/WifiManage.cpp (content) ⚔️ Tactility/Source/lvgl/LvglSync.cpp (content) ⚔️ Tactility/Source/service/memorychecker/MemoryCheckerService.cpp (content) ⚔️ Tactility/Source/service/statusbar/Statusbar.cpp (content) ⚔️ Tactility/Source/service/webserver/WebServerService.cpp (content) These conflicts must be resolved before merging into main.	Resolve conflicts locally and push changes to this branch.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Rename icons, fix T-Lora Pager config and more' directly reflects the main changes: extensive icon renaming (LVGL_SYMBOL_* to LVGL_ICON_*), T-Lora Pager SD card configuration fix, and license updates.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch develop

⚔️ Resolve merge conflicts (beta)

• Auto-commit resolved conflicts to branch develop
• Create stacked PR with resolved conflicts
• Post resolved changes as copyable diffs in a comment

---

No actionable comments were generated in the recent review. 🎉

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)

Modules/lvgl-module/source/arch/lvgl_esp32.c (1)

1-1: ⚠️ Potential issue | 🟡 Minor

Update license header to Apache-2.0 for consistency with the public header.

The public header (lvgl_module.h) is licensed under Apache-2.0, but this implementation file uses GPL-3.0-only. Given the PR updates the public header to Apache and the description mentions "Apache added, GPL removed," this file's license should be updated to match.

Modules/lvgl-module/include/tactility/lvgl_module.h (1)

70-75: ⚠️ Potential issue | 🔴 Critical

POSIX implementation not updated with function rename.

The ESP32 implementation and header both declare lvgl_try_lock, but the POSIX implementation at lvgl_posix.c:46 still defines the old name lvgl_try_lock_timed. This creates a mismatch with the exported symbols and will cause linker errors on POSIX platforms. The internal call at lvgl_posix.c:78 also needs to be updated to use the new function name.

Additionally, the documentation says "Timeout in ticks" (line 72) but both implementations call millis_to_ticks(timeout), meaning the parameter expects milliseconds, not ticks. Update the @param documentation to reflect this.