Skip to content

fix(settings): center SettingToggle knob#219

Merged
debba merged 1 commit into
TabularisDB:mainfrom
verbaux:fix/setting-toggle-alignment
May 19, 2026
Merged

fix(settings): center SettingToggle knob#219
debba merged 1 commit into
TabularisDB:mainfrom
verbaux:fix/setting-toggle-alignment

Conversation

@verbaux
Copy link
Copy Markdown
Contributor

@verbaux verbaux commented May 18, 2026

The knob was rendered via ::after on <input type="checkbox">. Pseudo-elements on void elements have implementation-defined behavior; on WebKit (Tauri/macOS) the knob landed below the center of the track.

Rewrite as <label> + peer sr-only <input> + two <span aria-hidden> for track and knob. Vertical centering comes from flex items-center on the label (geometric, no transform). Same size, colors, and API.

Noticed while reading SettingControls.tsx referenced in #195.

Before / After

Before After
image image

Test plan

  • pnpm typecheck clean
  • pnpm lint clean
  • pnpm test — 31/31 pass (one assertion updated to query the label, where cursor-not-allowed now lives)
  • Manual: click, keyboard (Space), disabled state, animation

@debba
Copy link
Copy Markdown
Collaborator

debba commented May 18, 2026

Hey :)
Looks wonderful, I will check better and merge ASAP.
Are you interested in #195 ?
We are looking for contributors in that area.

@verbaux
Copy link
Copy Markdown
Contributor Author

verbaux commented May 18, 2026

Hi @debba!
I'm a developer, not a designer, so I can't lead the visual direction or propose a palette/logo from scratch. But I'm happy to help with implementation.

If I spot inconsistencies along the way, I'll keep fixing them. Also, I'd love to help with localisation into Russian, if you don't mind.

@debba
Copy link
Copy Markdown
Collaborator

debba commented May 18, 2026

@verbaux sure feel free to open a PR for localisation

@debba debba merged commit b2c0eb0 into TabularisDB:main May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants