Skip to content

fix: cloning repositories#40

Open
olevski wants to merge 1 commit intomainfrom
fix-cloning-repos
Open

fix: cloning repositories#40
olevski wants to merge 1 commit intomainfrom
fix-cloning-repos

Conversation

@olevski
Copy link
Member

@olevski olevski commented Feb 16, 2025

Before this any compilation feature would not work on my computer when it came to cloning a repository.

And the error would consistenly be:

Project - Error cloning project: Error cloning project: there is no TLS stream available; class=Ssl (16)

Before this any compilation feature would not work on my computer when
it came to cloning a repository.
@olevski olevski requested review from a team as code owners February 16, 2025 21:07
@olevski
Copy link
Member Author

olevski commented Feb 16, 2025

This change is part of the following stack:

Change managed by git-spice.

@Panaetius
Copy link
Member

Panaetius commented Feb 17, 2025

did you see #39 that fixes this and also some other issues (project clone URL is out of date). Not sure how to best combine these. I do not remember what the issue on that other PR was that it's still in draft.

[edit]
OK I looked at it a bit and I think there's three relevant fixes in that one:

  • Unicode-DFS-2016 license wasn't found by the cargo audit/cargo deny command so I had to change that to the proper license name in deny.toml . It seems like this is no longer an issue
  • if a git url ends with e.g. renku.git, the cloned folder in the directory will be renku.git as well instead of just renku
  • parsing of project URLs is weirdly implemented and also wrong, plus the API endpoint in the backend changed, as URLs in the UI have since changed, I'd replaced that with regex parsing and correct UI URLs.

@olevski
Copy link
Member Author

olevski commented Feb 17, 2025

@Panaetius I just looked at the list of PRs before doing this, saw that #39 is a draft and I assumed it is not fully implemented. Also I did not know that http url cloning worked so I assumed by the title of #39 that that is fixing some very specific issue.

I guess I should review #39?

@olevski olevski closed this Feb 17, 2025
@olevski olevski reopened this Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants