Skip to content

Ghcr push workflow#14

Merged
BryceStevenWilley merged 4 commits into
v1.9.6.post1from
ghcr-push-workflow
Apr 2, 2026
Merged

Ghcr push workflow#14
BryceStevenWilley merged 4 commits into
v1.9.6.post1from
ghcr-push-workflow

Conversation

@rajeswari1301
Copy link
Copy Markdown

What this does:

@rajeswari1301
Copy link
Copy Markdown
Author

rajeswari1301 commented Apr 1, 2026

Also, wanted to add caching to the workflow- was thinking about it since the Docassemble docker file is pretty heavy(lots of python packages, NLTK downlaods, pandoc, etc). Without caching every build starts from scratch which could take some time.

So the idea is to use inline registry cache since we're already pushing to GHCR anyway - cache gets stored in the image itself and reused on the next build. Just the two lines to add:
cache-from: type=registry,ref=ghcr.io/${{ github.repository }}:latest
cache-to: type=inline

References I looked at:

Not a blocker for the PR, just thought it was worth adding.

Copy link
Copy Markdown

@BryceStevenWilley BryceStevenWilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I don't think we'll need to run on pull requests (mostly because most won't be targeting master).

I'll make that change and maybe retarget the PR to a new branch. There will have to be a lot of copying of commits around.

Comment thread .github/workflows/push-to-ghcr.yml Outdated
@BryceStevenWilley BryceStevenWilley changed the base branch from master to v1.9.6.post1 April 1, 2026 21:32
@BryceStevenWilley BryceStevenWilley merged commit 409a411 into v1.9.6.post1 Apr 2, 2026
3 checks passed
@BryceStevenWilley BryceStevenWilley deleted the ghcr-push-workflow branch April 2, 2026 12:58
BryceStevenWilley pushed a commit that referenced this pull request Apr 2, 2026
* Added action workflow to build and push docker image to GHCR

* Remove pull_request target
rajeswari1301 added a commit that referenced this pull request Apr 3, 2026
Follow up to #14.

Added inline registry caching to the build step. With this, docker uses reused unchanged layers from the last pushed image, so only the changed parts gets rebuilt again.
@rajeswari1301 rajeswari1301 mentioned this pull request Apr 3, 2026
BryceStevenWilley pushed a commit that referenced this pull request Apr 8, 2026
Follow up to #14.

Added inline registry caching to the build step. With this, docker uses reused unchanged layers from the last pushed image, so only the changed parts gets rebuilt again.
BryceStevenWilley pushed a commit that referenced this pull request Apr 9, 2026
* Added action workflow to build and push docker image to GHCR

* Remove pull_request target
BryceStevenWilley pushed a commit that referenced this pull request Apr 14, 2026
* Added action workflow to build and push docker image to GHCR

* Remove pull_request target

Add support for multiple platforms in Docker build

Linux amd64 was supported by default, but for newer Macs, arm64 is useful to have. Otherwise, we get a warning:

```
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants