Correct filename when only one file in bundle#1038
Merged
Conversation
BryceStevenWilley
approved these changes
Apr 2, 2026
Contributor
BryceStevenWilley
left a comment
BryceStevenWilley
left a comment
There was a problem hiding this comment.
Looks good to me!
|
Thanks so much for working on this! Do you anticipate it being merged soon? |
Contributor
|
I'm okay with merging this now. We're in LITCon today, so we won't be able to do a full release to PyPI until later this week probably though. |
|
I am still experiencing this issue when testing the Judgement of divorce for MLH. Is there anything we need to edit on our end to ensure this file shows the correct filename? For context, in the judgment bundle, each template has its own filename, and everything is nested within the main bundle to create a single document. Emailed docs: JSON from test case: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1036, fix #1035
Explicitly sets filename in more circumstances. This fixes filename issue with https://github.com/mplp/docassemble-MLHDivorceAndCustody in interactive end to end test; before upgrade, can reproduce file.pdf behavior. after switching to this branch, file is correctly named.