Skip dynamic code: fields in multi-field no-label accessibility check#35
Merged
nonprofittechy merged 2 commits intomainfrom May 1, 2026
Merged
Conversation
Agent-Logs-Url: https://github.com/SuffolkLITLab/DAYamlChecker/sessions/d1322216-aff4-435b-918c-362029af4c35 Co-authored-by: nonprofittechy <7645641+nonprofittechy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix accessibility error for dynamic code field without label
Skip dynamic May 1, 2026
code: fields in multi-field no-label accessibility check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A field entry of the form
- code: |(dynamic code field) was incorrectly triggering theno-label-on-multi-field-screenaccessibility error because it has no static label by design — its fields are generated at runtime.Changes
accessibility.py—_check_multifield_no_label_usagenow skips any field entry that contains a"code"key, since these entries expand dynamically and cannot have a static label:tests/test_yaml_structure.py— adds a regression test covering a multi-field screen that mixes a- code:entry with normal labeled fields, asserting no accessibility error is raised.Example that previously errored but should be valid: