Skip to content

Wrap custom html field labels in error class when showing in field validation messages #3049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AbdiTolesa wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Wrap custom html field labels in error class when showing in field validation messages #3049

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
135b0b2
Wrap custom html field labels in error class when not
AbdiTolesa Mar 27, 2026
f69f6b1
Add comment to clarify code
AbdiTolesa Mar 27, 2026
f840fe9
Refactor code
AbdiTolesa Mar 27, 2026
70f3325
Update function description
AbdiTolesa Mar 27, 2026
a1568a9
Fix eslint errors
AbdiTolesa Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 25 additions & 9 deletions js/formidable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1132,6 +1132,30 @@ function frmFrontFormJS() {
return kvp.join( '&' );
}

/**
* Returns HTML that is wrapped in the error class so that it can be removed with removeAllErrors().
*
* @since x.x
*
* @param {string} errorMessage The error message to wrap.
* @param {string} id The ID to use for the error element.
*
* @return {string} The error HTML.
*/
function getErrorHtml( errorMessage, id ) {
const roleString = frm_js.include_alert_role ? 'role="alert"' : '';

if ( ! errorMessage.startsWith( '<div' ) ) {
return `<div class="frm_error" ${ roleString } id="${ id }">${ errorMessage }</div>`;
}

const tempDiv = document.createElement( 'div' );
tempDiv.innerHTML = errorMessage;
tempDiv.firstChild.classList.add( 'frm_error' );

return tempDiv.innerHTML;
}

function addFieldError( $fieldCont, key, jsErrors ) {
const container = $fieldCont instanceof jQuery ? $fieldCont.get( 0 ) : $fieldCont;

Expand All @@ -1148,15 +1172,7 @@ function frmFrontFormJS() {
if ( typeof frmThemeOverride_frmPlaceError === 'function' ) { // eslint-disable-line camelcase
frmThemeOverride_frmPlaceError( key, jsErrors );
} else {
let errorHtml;
if ( jsErrors[ key ].includes( '<div' ) ) {
errorHtml = jsErrors[ key ];
} else {
const roleString = frm_js.include_alert_role ? 'role="alert"' : '';
errorHtml = `<div class="frm_error" ${ roleString } id="${ id }">${ jsErrors[ key ] }</div>`;
}
container.insertAdjacentHTML( 'beforeend', errorHtml );

container.insertAdjacentHTML( 'beforeend', getErrorHtml( jsErrors[ key ], id ) );
if ( input ) {
if ( ! describedBy ) {
describedBy = id;
Expand Down
Loading